Skip to content

KAFKA-6793: Unused configuration logging appears to be noisy and unnecessary #13225

Merged
hachikuji merged 3 commits intoapache:trunkfrom
philipnee:change-log-unused-level
Feb 13, 2023
Merged

KAFKA-6793: Unused configuration logging appears to be noisy and unnecessary #13225
hachikuji merged 3 commits intoapache:trunkfrom
philipnee:change-log-unused-level

Conversation

@philipnee
Copy link
Copy Markdown
Contributor

Reviving this old discussion, apparently the PR was closed so I reopened another one.

Issue: Recently we've encountered complaints about the warning being too noisy, therefore we want to reduce it to debug level.

The original PR was closed in : https://issues.apache.org/jira/browse/KAFKA-6793

Questions
Is this log useful at all? Should we just remove it?

@philipnee philipnee changed the title KAFKA-6793 KAFKA-6793: Unused configuration logging appears to be noisy and unnecessary Feb 9, 2023
@philipnee
Copy link
Copy Markdown
Contributor Author

@hachikuji - info level logging to prevent misleading warn.

Copy link
Copy Markdown
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Most of the time, this is an expected message, so info level seems more appropriate. At least we'll still have it in the logs in case it does hint at a real problem.

@philipnee
Copy link
Copy Markdown
Contributor Author

Failing tests seem unrelated (also appear to be flaky)

Build / JDK 17 and Scala 2.13 / testGracefulClose() – org.apache.kafka.clients.consumer.KafkaConsumerTest
1s
Build / JDK 17 and Scala 2.13 / [1] Type=ZK, Name=testMigrate, MetadataVersion=3.4-IV0, Security=PLAINTEXT – kafka.zk.ZkMigrationIntegrationTest
9s
Build / JDK 8 and Scala 2.12 / testLargeAssignmentAndGroupWithNonEqualSubscription() – org.apache.kafka.clients.consumer.StickyAssignorTest
1m 30s
Build / JDK 8 and Scala 2.12 / [1] Type=ZK, Name=testMigrate, MetadataVersion=3.4-IV0, Security=PLAINTEXT – kafka.zk.ZkMigrationIntegrationTest
12s

@C0urante
Copy link
Copy Markdown
Contributor

Huge +1 to demoting these. They've made the WARN level basically useless in Kafka Connect with the amount of noise they generate on startup, and the underlying strategy we use to track unused configs is just not intelligent enough to accommodate reasonable use cases like transparent passthrough of properties from one instantiated object to a plugin for it later on (i.e., after its AbstractConfig has already been instantiated).

Copy link
Copy Markdown
Contributor

@C0urante C0urante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @philipnee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants