KAFKA-14680: spotlessCheck task is disabled

[dejan2609]

Note: this solves build regression (after Gradle version was bumped from 7.6 to 8.0.1)

Rationale: see this comment made by @chia7712: #13205 (comment)

@chia7712 Feel free to test/review

FIY @ijuma

Some resources used for this solution:

• https://docs.gradle.org/8.0.1/userguide/more_about_tasks.html#sec:skipping_tasks
• https://stackoverflow.com/questions/33909943/exclude-tasks-from-the-task-that-my-task-depends-on
• https://stackoverflow.com/questions/35076540/can-gradle-task-dependencies-be-set-up-to-exclude-a-task

[chia7712]

LGTM, and it works well

[ijuma]

Not sure about this - seems like we're better off removing spotless altogether. Let me play with it a bit and see if something better can be done.

[dejan2609]

Got it @ijuma.

I removed redundant line (as proposed by @chia7712) but I do agree that solution is maybe an overkill, so to say.

My idea was to prevent tasks (such as build and check) that depend on spotless plugin related tasks to fail:

./gradlew build tiTree

> Task :tiTree
:build                                                         (org.gradle.api.DefaultTask)
+--- :assemble                                                 (org.gradle.api.DefaultTask)
|    `--- :jar                                                 (org.gradle.api.tasks.bundling.Jar)
|         +--- :classes                                        (org.gradle.api.DefaultTask)
|         |    +--- :compileJava                               (org.gradle.api.tasks.compile.JavaCompile)
|         |    `--- :processResources                          (org.gradle.language.jvm.tasks.ProcessResources)
|         `--- :compileJava                                    (org.gradle.api.tasks.compile.JavaCompile)
`--- :check                                                    (org.gradle.api.DefaultTask)
     +--- :rat                                                 (org.nosphere.apache.rat.RatTask)
     +--- :spotlessCheck                                       (org.gradle.api.DefaultTask)
     |    `--- :spotlessScalaCheck                             (com.diffplug.gradle.spotless.SpotlessCheck)
     |         `--- :spotlessScala                             (com.diffplug.gradle.spotless.SpotlessTaskImpl)
     |              `--- :spotlessInternalRegisterDependencies (com.diffplug.gradle.spotless.RegisterDependenciesTask)
     `--- :test                                                (org.gradle.api.tasks.testing.Test)
          +--- :classes                                        (org.gradle.api.DefaultTask)
          |    +--- :compileJava                               (org.gradle.api.tasks.compile.JavaCompile)
          |    `--- :processResources                          (org.gradle.language.jvm.tasks.ProcessResources)
          +--- :compileJava                                    (org.gradle.api.tasks.compile.JavaCompile)
          +--- :compileTestJava                                (org.gradle.api.tasks.compile.JavaCompile)
          |    +--- :classes                                   (org.gradle.api.DefaultTask)
          |    |    +--- :compileJava                          (org.gradle.api.tasks.compile.JavaCompile)
          |    |    `--- :processResources                     (org.gradle.language.jvm.tasks.ProcessResources)
          |    `--- :compileJava                               (org.gradle.api.tasks.compile.JavaCompile)
          `--- :testClasses                                    (org.gradle.api.DefaultTask)
               +--- :compileTestJava                           (org.gradle.api.tasks.compile.JavaCompile)
               |    +--- :classes                              (org.gradle.api.DefaultTask)
               |    |    +--- :compileJava                     (org.gradle.api.tasks.compile.JavaCompile)
               |    |    `--- :processResources                (org.gradle.language.jvm.tasks.ProcessResources)
               |    `--- :compileJava                          (org.gradle.api.tasks.compile.JavaCompile)
               `--- :processTestResources                      (org.gradle.language.jvm.tasks.ProcessResources)

[ijuma]

@dejan2609 @chia7712 Check this alternative approach and let me know what you think:

https://github.com/apache/kafka/pull/13311/files

[dejan2609]

Closing in favor of #13311