KAFKA-14767: Fix missing commitId build error after git gc#13315
KAFKA-14767: Fix missing commitId build error after git gc#13315ijuma merged 7 commits intoapache:trunkfrom
Conversation
Signed-off-by: Greg Harris <greg.harris@aiven.io>
| headRef.trim().take(takeFromHash) | ||
| } | ||
| } else if (file("$rootDir/.git").exists()) { | ||
| def repo = Grgit.open(currentDir: project.getRootDir()) |
There was a problem hiding this comment.
The rat configuration does something similar, maybe we should have a variable for the git repo that can be used by both tasks.
Signed-off-by: Greg Harris <greg.harris@aiven.io>
|
Looks like the build failed. |
Signed-off-by: Greg Harris <greg.harris@aiven.io>
|
@ijuma I don't know how my change would impact the execution order of rat vs processTestMessages, do you have any intuition? The commitId change that I originally proposed (without the deduplication of the Grgit call) didn't experience this failure; do you think we could merge the commitId improvement and follow up on the rat implicit dependencies in another PR if the latest commit doesn't fix the build? |
|
It appears that the mustRunAfter directive has fixed the build, and now it's just normal flakey tests. I won't be reverting the fixups and should be ready for review. |
|
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) |
|
@ijuma I'd still like to get this merged, please take another review pass, thanks! |
Signed-off-by: Greg Harris <greg.harris@aiven.io>
…g-commit-id Signed-off-by: Greg Harris <greg.harris@aiven.io>
|
The rat problem was fixed in #13854 so i'm removing my fix for it in this PR. |
|
This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch) If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. |
|
Hey @ijuma @divijvaidya @C0urante or @yashmayya Could you review this build improvement? I'm still getting this I'd like to backport this to 3.4, 3.5, and 3.6. |
|
Well, Jenkins failed - we need to firs that first. |
|
Build looks good, merging. |
git gc moves commit hashes from individual .git/refs/heads/ to .git/packed-refs which is not read by the determineCommitId function. Replace the existing lookup within the .git directory with a GrGit lookup that handles packed and unpacked refs transparently. Reviewers: Ismael Juma <ismael@juma.me.uk>
git gc moves commit hashes from individual .git/refs/heads/ to .git/packed-refs which is not read by the determineCommitId function. Replace the existing lookup within the .git directory with a GrGit lookup that handles packed and unpacked refs transparently. Reviewers: Ismael Juma <ismael@juma.me.uk>
git gc moves commit hashes from individual .git/refs/heads/ to .git/packed-refs which is not read by the determineCommitId function. Replace the existing lookup within the .git directory with a GrGit lookup that handles packed and unpacked refs transparently. Reviewers: Ismael Juma <ismael@juma.me.uk>
) git gc moves commit hashes from individual .git/refs/heads/ to .git/packed-refs which is not read by the determineCommitId function. Replace the existing lookup within the .git directory with a GrGit lookup that handles packed and unpacked refs transparently. Reviewers: Ismael Juma <ismael@juma.me.uk>
2 participants
git gcmoves commit hashes from individual.git/refs/heads/to.git/packed-refswhich is not read by the determineCommitId function.Replace the existing lookup within the
.gitdirectory with a GrGit lookup that handles packed and unpacked refs transparently.Committer Checklist (excluded from commit message)