KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest#13383
Merged
C0urante merged 15 commits intoapache:trunkfrom Jul 10, 2023
Merged
KAFKA-14059 Replace PowerMock with Mockito in WorkerSourceTaskTest#13383C0urante merged 15 commits intoapache:trunkfrom
C0urante merged 15 commits intoapache:trunkfrom
Conversation
C0urante
reviewed
Mar 21, 2023
Contributor
C0urante
left a comment
C0urante
left a comment
There was a problem hiding this comment.
Thanks @hgeraldino! I've made it about halfway through in this pass; will try to revisit this week or the next and look at the rest.
Also, similar to #13191 (comment), can we add verifyNoMoreInteractions(statusListener); to the test's tearDown method?
Contributor
Author
Good catch, will add it. |
hgeraldino
force-pushed
the
workersourcetask
branch
2 times, most recently
from
6197644 to
1e46ec4
Compare
Contributor
Author
|
Thanks for your feedback @C0urante. I finally had time this past week and tweaked the test to address your comments and fix coverage. |
C0urante
reviewed
Jun 2, 2023
C0urante
reviewed
Jun 2, 2023
Contributor
C0urante
left a comment
C0urante
left a comment
There was a problem hiding this comment.
Thanks @hgeraldino! Apologies for the wait, releases, Kafka Summit London, and a few other things have made it difficult to find for review over the last few weeks.
I've finished a complete pass over the PR; once everything is addressed this should be good to merge.
hgeraldino
force-pushed
the
workersourcetask
branch
2 times, most recently
from
4037471 to
357f582
Compare
Contributor
Author
|
Thanks @C0urante for your thoroughly review! I think I've addressed all your comments. I've also picked up the work to have the |
C0urante
reviewed
Jun 5, 2023
Contributor
C0urante
left a comment
C0urante
left a comment
There was a problem hiding this comment.
Thanks @hgeraldino, really close!
…/WorkerSourceTaskTest.java Co-authored-by: Chris Egerton <fearthecellos@gmail.com>
…/WorkerSourceTaskTest.java Co-authored-by: Chris Egerton <fearthecellos@gmail.com>
…/WorkerSourceTaskTest.java Co-authored-by: Chris Egerton <fearthecellos@gmail.com>
…/WorkerSourceTaskTest.java Co-authored-by: Chris Egerton <fearthecellos@gmail.com>
…/WorkerSourceTaskTest.java Co-authored-by: Chris Egerton <fearthecellos@gmail.com>
hgeraldino
force-pushed
the
workersourcetask
branch
from
ca46a7c to
0b4c2fa
Compare
C0urante
reviewed
Jul 6, 2023
Contributor
C0urante
left a comment
C0urante
left a comment
There was a problem hiding this comment.
Thanks @hgeraldino! Some final suggestions and then this will be good to go. I think it's important that these messages are accurate as they help illustrate the purpose of these tests and may save time for developers who have to read/rewrite them in the future.
…/WorkerSourceTaskTest.java Co-authored-by: Chris Egerton <fearthecellos@gmail.com>
…/WorkerSourceTaskTest.java Co-authored-by: Chris Egerton <fearthecellos@gmail.com>
…/WorkerSourceTaskTest.java Co-authored-by: Chris Egerton <fearthecellos@gmail.com>
…/WorkerSourceTaskTest.java Co-authored-by: Chris Egerton <fearthecellos@gmail.com>
Contributor
Author
C0urante
reviewed
Jul 10, 2023
Contributor
C0urante
left a comment
C0urante
left a comment
There was a problem hiding this comment.
Thanks @hgeraldino, LGTM!
C0urante
approved these changes
Jul 10, 2023
Cerchie
pushed a commit
to Cerchie/kafka
that referenced
this pull request
Jul 25, 2023
…pache#13383) Reviewers: Chris Egerton <chrise@aiven.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows more or less the same principles as #13191
Committer Checklist (excluded from commit message)