KAFKA-10244 An new java interface to replace 'kafka.common.MessageReader'#13393
KAFKA-10244 An new java interface to replace 'kafka.common.MessageReader'#13393chia7712 merged 12 commits intoapache:trunkfrom
Conversation
mimaison
left a comment
There was a problem hiding this comment.
Thanks for the PR! I left a few comments.
|
@mimaison thanks for reviews. I have addressed all comments. please take a look, thanks! |
mimaison
left a comment
There was a problem hiding this comment.
Thanks for the updates. LGTM
unrelated error. will merge it later |
|
Since this is a public api, we need to enable javadoc generation for it. Have we done that? |
|
One additional issue is that we are introducing a new "split packages" situation. We already have some of those, but we should probably not add new ones for public apis due to https://www.logicbig.com/tutorials/core-java-tutorial/modules/split-packages.html |
I will address it later.
thanks for nice reminder. the alternative is |
related to https://issues.apache.org/jira/browse/KAFKA-10244
kafka.common.MessageReaderis a input argument of kafka-console-producer and we expect users can have their custom reader to produce custom records. Hence, MessageReader is a public interface and we should offer a java version to replace current scala code. Also, the new MessageReader should be placed at clients module. (kafka.common.MessageReader is in core module)Committer Checklist (excluded from commit message)