KAFKA-6891: send.buffer.bytes should be allowed to set -1 in KafkaConnect#13398
KAFKA-6891: send.buffer.bytes should be allowed to set -1 in KafkaConnect#13398chia7712 merged 5 commits intoapache:trunkfrom
Conversation
|
@garyparrot nice catch. It is not only typo but also incorrect validation. the |
|
@chia7712 Thanks for your opinion. Indeed this issue should be treated as a bug (The contribution guide has addressed this, sorry I am not familiar with the rules here). I find this issue has already been mentioned at KAFKA-6891. I have self-assigned that issue and updated the description. Please take another look, thanks. |
chia7712
left a comment
There was a problem hiding this comment.
LGTM. thanks for this contribution.
|
@garyparrot could you rebase PR to trigger QA again? |
|
linked to stale PR (#4995) |
|
Sure thing. |
|
@garyparrot could you merge trunk to trigger QA again? |
the tests pass. will merge it later |
|
@garyparrot thanks for this contribution |
What changes were proposed in this pull request?
Fix the incorrect valid range of the following Kafka connect configs: send.buffer.bytes and receive.buffer.bytes.
Currently, the valid values start from
0, although the documentation states-1is also a valid value.How was this patch tested?
Add relevant unit test to
DistributedConfigTest.Committer Checklist (excluded from commit message)