KAFKA-14834: [4/N] Drop out-of-order records from table-table join with versioned tables#13510
Merged
mjsax merged 4 commits intoapache:trunkfrom Apr 13, 2023
Merged
Conversation
vcrfxia
force-pushed
the
kip-914-table-table-join
branch
from
18e478f to
1e78965
Compare
vcrfxia
commented
Apr 7, 2023
Contributor
Author
There was a problem hiding this comment.
Just checking: adding state stores to an existing processor topology is a backwards-compatible change, right? I can't think of why it wouldn't be, but if it's not then that would mean compatibility concerns for this PR.
Member
There was a problem hiding this comment.
Yes. We only give access to an existing store (within the same sub-topology). No compatibility concern.
vcrfxia
force-pushed
the
kip-914-table-table-join
branch
from
30df37e to
80163bc
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates primary-key table-table join processors to ignore out-of-order records from versioned tables, as specified in KIP-914. Foreign-key table-table joins will be updated in a subsequent PR.
Committer Checklist (excluded from commit message)