Skip to content

KAFKA-14462; [4/N] Add Group, Record and Result#13520

Merged
dajac merged 3 commits intoapache:trunkfrom
dajac:KAFKA-14462-4-1
Apr 12, 2023
Merged

KAFKA-14462; [4/N] Add Group, Record and Result#13520
dajac merged 3 commits intoapache:trunkfrom
dajac:KAFKA-14462-4-1

Conversation

@dajac
Copy link
Copy Markdown
Member

@dajac dajac commented Apr 6, 2023

This PR extracts a few classes from #13476.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dajac dajac added the KIP-848 The Next Generation of the Consumer Rebalance Protocol label Apr 6, 2023
@dajac dajac requested a review from hachikuji April 6, 2023 15:00
Copy link
Copy Markdown
Contributor

@jeffkbkim jeffkbkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor comments

Comment thread group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Record.java Outdated
Comment thread group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Record.java Outdated
@dajac dajac changed the title KAFKA-14462; [4.1/N] Add Group, Record and Result KAFKA-14462; [4/N] Add Group, Record and Result Apr 11, 2023
Copy link
Copy Markdown
Contributor

@jeffkbkim jeffkbkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a minor comment

@dajac dajac merged commit e1e3900 into apache:trunk Apr 12, 2023
@dajac dajac deleted the KAFKA-14462-4-1 branch April 12, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

KIP-848 The Next Generation of the Consumer Rebalance Protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants