KAFKA-14834: [10/N] Reserve repartition topic formats to include isLatest#13566
Merged
mjsax merged 1 commit intoapache:trunkfrom Apr 14, 2023
Merged
Conversation
76584d5 to
c16fb68
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#13564 introduced a new boolean
isLatestintoChangeto indicate whether a change update represents the latest for the key. Even thoughChangeis serialized into the table repartition topic, the new boolean does not need to be serialized in, because the table repartition map processor performs an optimization to drop records for whichisLatest = false. If not for this optimization, the downstream table aggregate would have to drop such records instead, andisLatestwould need to be serialized into the repartition topic.In light of the possibility that
isLatestmay need to be serialized into the repartition topic in the future, e.g., if other downstream processors are added which need to distinguish between records for whichisLatest = truevsisLatest = false, this PR reserves repartition topic formats which includeisLatest. Reserving these formats now comes at no additional cost to users since a rolling bounce is already required for the upcoming release due to #10747. If we don't reserve them now and instead have to add them later, then another bounce would be required at that time. Reserving formats is cheap, so we choose to do it now.Committer Checklist (excluded from commit message)