Skip to content

MINOR: Upgrade to Gradle 8.1#13569

Closed
ijuma wants to merge 1 commit intoapache:trunkfrom
ijuma:gradle-8.1
Closed

MINOR: Upgrade to Gradle 8.1#13569
ijuma wants to merge 1 commit intoapache:trunkfrom
ijuma:gradle-8.1

Conversation

@ijuma
Copy link
Copy Markdown
Member

@ijuma ijuma commented Apr 14, 2023

Release notes:
https://docs.gradle.org/8.1/release-notes.html

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma ijuma requested a review from omkreddy April 14, 2023 13:50
@bmscomp
Copy link
Copy Markdown
Contributor

bmscomp commented Apr 15, 2023

I think it's enough to use a bin distribution type instead instead of all one for Gradle wrapper

@divijvaidya
Copy link
Copy Markdown
Member

A new big fix release is available 8.1.1 and the release notes mention: "We recommend users upgrade to 8.1.1 instead of 8.1."

I would suggest to discard this PR and instead review #13625

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Apr 25, 2023

It's a little odd to create a new PR instead of simply updating the one that's open...

@bmscomp
Copy link
Copy Markdown
Contributor

bmscomp commented Apr 25, 2023

@ijuma Apologies, may be it's more wise to close the one I created and keep updating this one, I'll update my pull request since it contains also some Gradle plugin upgrades

@ijuma
Copy link
Copy Markdown
Member Author

ijuma commented Apr 25, 2023

In the future, please try to work with the contributor who submitted a PR instead of creating your own. In this case, I went ahead and merged your PR and closed this one.

@ijuma ijuma closed this Apr 25, 2023
@bmscomp
Copy link
Copy Markdown
Contributor

bmscomp commented Apr 25, 2023

@ijuma Yes of course, I'll do that , this is the first PR ever for me in this repo, I'll keep learning from all of you

@divijvaidya
Copy link
Copy Markdown
Member

Thank you for making this is a teaching moment @ijuma. I will try to do better reviews, keeping in mind your suggestion in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants