KAFKA-14737: Move kafka.utils.json to server-common#13585
Merged
mimaison merged 1 commit intoapache:trunkfrom Jul 18, 2023
Merged
KAFKA-14737: Move kafka.utils.json to server-common#13585mimaison merged 1 commit intoapache:trunkfrom
mimaison merged 1 commit intoapache:trunkfrom
Conversation
OmniaGM
force-pushed
the
KAFKA-14737
branch
6 times, most recently
from
f16a1cd to
0f083d9
Compare
OmniaGM
changed the title
3 tasks
fvaleri
approved these changes
Jul 8, 2023
Contributor
Author
Thanks for the review. I fixed the import errors |
mimaison
reviewed
Jul 12, 2023
Member
mimaison
left a comment
mimaison
left a comment
There was a problem hiding this comment.
Thanks for the PR! I left one question.
Member
There was a problem hiding this comment.
Do we need this catch is we rethrow the same exception directly?
Same in decodeMap() below
Contributor
Author
There was a problem hiding this comment.
Probably not, I was trying to stick to the original interface (which doesn't have any exception in the signature) as much as I could in case we switched everything to use this new class instead.
Contributor
Author
There was a problem hiding this comment.
I removed the try/catch
OmniaGM
force-pushed
the
KAFKA-14737
branch
2 times, most recently
from
3631fcf to
b13a2b9
Compare
jolshan
added a commit
to confluentinc/kafka
that referenced
this pull request
Jul 18, 2023
* ak/trunk: (110 commits) MINOR: Update docs to include ZK deprecation notice and information (apache#14031) KAFKA-15091: Fix misleading Javadoc for SourceTask::commit (apache#13948) KAFKA-14669: Use the generated docs for MirrorMaker configs in the doc (apache#13658) KAFKA-14953: Add tiered storage related metrics (apache#13944) KAFKA-15121: Implement the alterOffsets method in the FileStreamSourceConnector and the FileStreamSinkConnector (apache#13945) Revert "MINOR: Update .asf.yaml file with refreshed github_whitelist, and collaborators" (apache#14037) MINOR: Update .asf.yaml file with refreshed github_whitelist, and collaborators KAFKA-14737: Move kafka.utils.json to server-common (apache#13585) KAFKA-14647: Move TopicFilter to server-common/utils (apache#13158) MINOR: remove unused variable in examples (apache#14021) ...
jeqo
pushed a commit
to jeqo/kafka
that referenced
this pull request
Jul 21, 2023
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Federico Valeri <fedevaleri@gmail.com>
Cerchie
pushed a commit
to Cerchie/kafka
that referenced
this pull request
Jul 25, 2023
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Federico Valeri <fedevaleri@gmail.com>
jeqo
pushed a commit
to aiven/kafka
that referenced
this pull request
Aug 15, 2023
Reviewers: Mickael Maison <mickael.maison@gmail.com>, Federico Valeri <fedevaleri@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a replica of
kafka.utils.json, we can decide to switch toorg.apache.kafka.server.util.jsoneverywhere later.More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)