Skip to content

KAFKA-14869: Ignore unknown record types for coordinators (KIP-915, P…#13596

Merged
dajac merged 3 commits intoapache:3.0from
jeffkbkim:3.0-kafka-14869
Apr 21, 2023
Merged

KAFKA-14869: Ignore unknown record types for coordinators (KIP-915, P…#13596
dajac merged 3 commits intoapache:3.0from
jeffkbkim:3.0-kafka-14869

Conversation

@jeffkbkim
Copy link
Copy Markdown
Contributor

…art-1) (#13511)

This patch implemented the first part of KIP-915. It updates the group coordinator and the transaction coordinator to ignores unknown record types while loading their respective state from the partitions. This allows downgrades from future versions that will include new record types.

Reviewers: Alexandre Dupriez alexandre.dupriez@gmail.com, David Jacot djacot@confluent.io

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…art-1) (apache#13511)

This patch implemented the first part of KIP-915. It updates the group coordinator and the transaction coordinator to ignores unknown record types while loading their respective state from the partitions. This allows downgrades from future versions that will include new record types.

Reviewers: Alexandre Dupriez <alexandre.dupriez@gmail.com>, David Jacot <djacot@confluent.io>
@dajac
Copy link
Copy Markdown
Member

dajac commented Apr 20, 2023

@jeffkbkim This PR has failures related to the change. Could you take a look?

Build / JDK 11 and Scala 2.13 / testLoadGroupsAndOffsetsWillIgnoreUnknownMessage() – kafka.coordinator.group.GroupMetadataManagerTest
<1s
Build / JDK 11 and Scala 2.13 / testLoadGroupsAndOffsetsWillIgnoreUnknownMessage() – kafka.coordinator.group.GroupMetadataManagerTest
<1s
Build / JDK 16 and Scala 2.13 / testLoadGroupsAndOffsetsWillIgnoreUnknownMessage() – kafka.coordinator.group.GroupMetadataManagerTest
<1s
Build / JDK 16 and Scala 2.13 / testLoadGroupsAndOffsetsWillIgnoreUnknownMessage() – kafka.coordinator.group.GroupMetadataManagerTest
<1s
Build / JDK 8 and Scala 2.12 / testLoadGroupsAndOffsetsWillIgnoreUnknownMessage() – kafka.coordinator.group.GroupMetadataManagerTest
<1s
Build / JDK 8 and Scala 2.12 / testLoadGroupsAndOffsetsWillIgnoreUnknownMessage() – kafka.coordinator.group.GroupMetadataManagerTest

@dajac dajac merged commit 9f37432 into apache:3.0 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants