Skip to content

KAFKA-14869: Bump coordinator value records to flexible versions (KIP…#13603

Merged
dajac merged 2 commits intoapache:3.3from
jeffkbkim:3.3-kafka-14869-2
Apr 25, 2023
Merged

KAFKA-14869: Bump coordinator value records to flexible versions (KIP…#13603
dajac merged 2 commits intoapache:3.3from
jeffkbkim:3.3-kafka-14869-2

Conversation

@jeffkbkim
Copy link
Copy Markdown
Contributor

…-915, Part-2) (#13526)

This patch implemented the second part of KIP-915. It bumps the versions of the value records used by the group coordinator and the transaction coordinator to make them flexible versions. The new versions are not used when writing to the partitions but only when reading from the partitions. This allows downgrades from future versions that will include tagged fields.

Reviewers: David Jacot djacot@confluent.io

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

…-915, Part-2) (apache#13526)

This patch implemented the second part of KIP-915. It bumps the versions of the value records used by the group coordinator and the transaction coordinator to make them flexible versions. The new versions are not used when writing to the partitions but only when reading from the partitions. This allows downgrades from future versions that will include tagged fields.

Reviewers: David Jacot <djacot@confluent.io>
@jeffkbkim
Copy link
Copy Markdown
Contributor Author

@dajac

org.apache.kafka.streams.integration.SmokeTestDriverIntegrationTest. shouldWorkWithRebalance
kafka.api.ConsumerBounceTest.testSubscribeWhenTopicUnavailable()

passed locally

@dajac
Copy link
Copy Markdown
Member

dajac commented Apr 21, 2023

@jeffkbkim Could you please rebase this one?

@jeffkbkim
Copy link
Copy Markdown
Contributor Author

jeffkbkim commented Apr 24, 2023

test failures are unrelated

Build / JDK 8 and Scala 2.12 / testDescribeQuorumRequestToBrokers() – kafka.server.KRaftClusterTest
31s
Build / JDK 8 and Scala 2.12 / testUpdateMetadataVersion() – kafka.server.KRaftClusterTest
19s
Build / JDK 17 and Scala 2.13 / testDescribeAtMinIsrPartitions(String).quorum=kraft – kafka.admin.TopicCommandIntegrationTest
12s
Build / JDK 11 and Scala 2.13 / testSeparateOffsetsTopic – org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest
2m 58s
Build / JDK 11 and Scala 2.13 / testSendOffsetsWithNoConsumerGroupWriteAccess(String).quorum=kraft – kafka.api.AuthorizerIntegrationTest
13s
Build / JDK 11 and Scala 2.13 / testConsumptionWithBrokerFailures() – kafka.api.ConsumerBounceTest
30s
Build / JDK 11 and Scala 2.13 / testCreateClusterAndCreateListDeleteTopic() – kafka.server.KRaftClusterTest

Copy link
Copy Markdown
Member

@dajac dajac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dajac dajac merged commit 8164a70 into apache:3.3 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants