KAFKA-14462; [14/N] Add PartitionWriter#13675
Merged
dajac merged 11 commits intoapache:trunkfrom Jun 6, 2023
Merged
Conversation
dajac
changed the title
jolshan
reviewed
May 31, 2023
jolshan
reviewed
May 31, 2023
jolshan
reviewed
May 31, 2023
jolshan
reviewed
May 31, 2023
jolshan
reviewed
May 31, 2023
3 tasks
jolshan
reviewed
Jun 2, 2023
Member
|
Hey David -- whenever we update appendRecords we have to modify a ton of tests that mock the method. (Basically add a ton of any(), since the mocker doesn't get default args). There are 283 failing now 😅 See here for an example of a PR that updates them: https://github.com/apache/kafka/pull/13391/files |
Member
Author
|
Yeah, I have noticed all the failed tests. I will fix them. |
jeffkbkim
reviewed
Jun 2, 2023
Member
|
These connect and kraft tests are a little concerning. They seem unrelated but maybe we should file a jira. |
jolshan
approved these changes
Jun 5, 2023
jeffkbkim
reviewed
Jun 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces the
PartitionWriterinterface in thegroup-coordinatormodule. TheReplicaManagerresides in thecoremodule and it is thus not accessible from thegroup-coordinatorone. ThePartitionWriterImplis basically an implementation of the interface residing incorewhich interfaces with theReplicaManager.One notable difference from the usual produce path is that the
PartitionWriterreturns the offset following the written records. This is then used by the coordinator runtime (coming later) to track when the request associated with the write can be completed.Committer Checklist (excluded from commit message)