KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFetchResponse - WIP#13764
Closed
clolov wants to merge 3 commits intoapache:trunkfrom
Closed
KAFKA-14691; [1/N] Add new fields to OffsetFetchRequest and OffsetFetchResponse - WIP#13764clolov wants to merge 3 commits intoapache:trunkfrom
clolov wants to merge 3 commits intoapache:trunkfrom
Conversation
Hangleton
reviewed
May 25, 2023
There was a problem hiding this comment.
nit: The "about" field could be on a new line.
There was a problem hiding this comment.
Do we want to add these fields in this PR?
Member
|
Since this is still under development, can we set the flag to indicate the latest version is unstable? |
Member
|
I have a few comments/questions:
|
Contributor
Author
I will accommodate 2 and 3 in subsequent commits. There was no reason for 1 other than splitting the pull request into nicer to review chunks. I am happy with trying to put Request/Respone changes + server side changes + tests in the same pull request similar to #13240. Thank you all for the reviews! |
Member
|
Closing this PR for now as the topic id work will be done later. We can re-open it when we resume the work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part 1 of KAFKA-14691. I change the JSON files which are used to generate the POJOs used during requests and responses.