KAFKA-14784: Connect offset reset REST API#13818
Merged
C0urante merged 7 commits intoapache:trunkfrom Jun 23, 2023
Merged
Conversation
Contributor
Author
Sink connector offsets alter requests:Source connector offsets alter requests:Sink connector offsets reset requests:Source connector offsets reset requests:The current flows for altering and resetting offsets along with the use of |
yashmayya
commented
Jun 6, 2023
C0urante
reviewed
Jun 7, 2023
Contributor
C0urante
left a comment
C0urante
left a comment
There was a problem hiding this comment.
This looks great, thanks Yash! I've made it through all of the functional changes and the integration tests; will review the unit tests in the next pass.
yashmayya
force-pushed
the
KAFKA-14784-offset-reset-api
branch
from
2170332 to
397b622
Compare
…ffsets; use a timer to bound total runtime for modifying connector offsets in the Worker; add integration test to verify various invalid offset scenarios while attempting to alter connector offsets; other minor logging and Javadoc improvements
yashmayya
force-pushed
the
KAFKA-14784-offset-reset-api
branch
from
e8fda70 to
355c687
Compare
C0urante
reviewed
Jun 21, 2023
Contributor
C0urante
left a comment
C0urante
left a comment
There was a problem hiding this comment.
Looking great! Some minor comments and then this should be ready to merge (pending CI build). Thanks Yash!
…urceConnector::alterOffsets and SinkConnector::alterOffsets
…nkConnector::alterOffsets
yashmayya
force-pushed
the
KAFKA-14784-offset-reset-api
branch
from
7907f2c to
cd4c1f2
Compare
Contributor
|
Test failures appear unrelated; merging... |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DELETE /connectors/{connector}/offsetsREST APICommitter Checklist (excluded from commit message)