Skip to content

KAFKA-15129;[7/N] Remove metrics in TransactionMarkerChannelManager when TransactionCoordinator shutdown#13962

Merged
divijvaidya merged 1 commit intoapache:trunkfrom
hudeqi:clean_metric_coordinator
Jul 7, 2023
Merged

KAFKA-15129;[7/N] Remove metrics in TransactionMarkerChannelManager when TransactionCoordinator shutdown#13962
divijvaidya merged 1 commit intoapache:trunkfrom
hudeqi:clean_metric_coordinator

Conversation

@hudeqi
Copy link
Copy Markdown
Contributor

@hudeqi hudeqi commented Jul 5, 2023

This pr is used to remove the metrics in TransactionMarkerChannelManager when TransactionCoordinator shutdown.
This pr has passed the corresponding unit test, and it is part of KAFKA-15129.

Copy link
Copy Markdown
Member

@divijvaidya divijvaidya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@divijvaidya
Copy link
Copy Markdown
Member

All test failures are flaky. The new ones are caused by thread leak not related to this PR.

[Build / JDK 11 and Scala 2.13 / kafka.server.ServerGenerateClusterIdTest.testAutoGenerateClusterIdForKafkaClusterParallel()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.server/ServerGenerateClusterIdTest/Build___JDK_11_and_Scala_2_13___testAutoGenerateClusterIdForKafkaClusterParallel__/)
[Build / JDK 11 and Scala 2.13 / kafka.server.ServerGenerateClusterIdTest.testAutoGenerateClusterId()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.server/ServerGenerateClusterIdTest/Build___JDK_11_and_Scala_2_13___testAutoGenerateClusterId__/)
[Build / JDK 11 and Scala 2.13 / kafka.server.ServerGenerateClusterIdTest.testAutoGenerateClusterIdForKafkaClusterSequential()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.server/ServerGenerateClusterIdTest/Build___JDK_11_and_Scala_2_13___testAutoGenerateClusterIdForKafkaClusterSequential__/)
[Build / JDK 11 and Scala 2.13 / kafka.server.ServerGenerateClusterIdTest.testInconsistentBrokerMetadataBetweenMultipleLogDirs()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.server/ServerGenerateClusterIdTest/Build___JDK_11_and_Scala_2_13___testInconsistentBrokerMetadataBetweenMultipleLogDirs__/)
[Build / JDK 11 and Scala 2.13 / kafka.server.ServerGenerateClusterIdTest.testInconsistentClusterIdFromZookeeperAndFromMetaProps()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.server/ServerGenerateClusterIdTest/Build___JDK_11_and_Scala_2_13___testInconsistentClusterIdFromZookeeperAndFromMetaProps__/)
[Build / JDK 11 and Scala 2.13 / kafka.server.ServerGenerateClusterIdTest.testConsistentClusterIdFromZookeeperAndFromMetaProps()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.server/ServerGenerateClusterIdTest/Build___JDK_11_and_Scala_2_13___testConsistentClusterIdFromZookeeperAndFromMetaProps__/)
[Build / JDK 11 and Scala 2.13 / kafka.server.ServerGenerateClusterIdTest.executionError](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.server/ServerGenerateClusterIdTest/Build___JDK_11_and_Scala_2_13___executionError/)
[Build / JDK 11 and Scala 2.13 / kafka.server.ServerShutdownTest.initializationError](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.server/ServerShutdownTest/Build___JDK_11_and_Scala_2_13___initializationError/)
[Build / JDK 11 and Scala 2.13 / kafka.server.UpdateFeaturesTest.initializationError](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.server/UpdateFeaturesTest/Build___JDK_11_and_Scala_2_13___initializationError/)
[Build / JDK 11 and Scala 2.13 / kafka.server.epoch.EpochDrivenReplicationProtocolAcceptanceWithIbp26Test.initializationError](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.server.epoch/EpochDrivenReplicationProtocolAcceptanceWithIbp26Test/Build___JDK_11_and_Scala_2_13___initializationError/)
[Build / JDK 11 and Scala 2.13 / kafka.utils.ReplicationUtilsTest.initializationError](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.utils/ReplicationUtilsTest/Build___JDK_11_and_Scala_2_13___initializationError/)
[Build / JDK 11 and Scala 2.13 / kafka.zk.migration.ZkConfigMigrationClientTest.initializationError](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.zk.migration/ZkConfigMigrationClientTest/Build___JDK_11_and_Scala_2_13___initializationError/)
[Build / JDK 11 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/org.apache.kafka.trogdor.coordinator/CoordinatorTest/Build___JDK_11_and_Scala_2_13___testTaskRequestWithOldStartMsGetsUpdated__/)
[Build / JDK 20 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.IdentityReplicationIntegrationTest.testSyncTopicConfigs()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/org.apache.kafka.connect.mirror.integration/IdentityReplicationIntegrationTest/Build___JDK_20_and_Scala_2_13___testSyncTopicConfigs__/)
[Build / JDK 20 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindReplicationFlow()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/org.apache.kafka.connect.mirror.integration/MirrorConnectorsIntegrationExactlyOnceTest/Build___JDK_20_and_Scala_2_13___testOffsetTranslationBehindReplicationFlow__/)
[Build / JDK 20 and Scala 2.13 / integration.kafka.server.FetchFromFollowerIntegrationTest.testRackAwareRangeAssignor()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/integration.kafka.server/FetchFromFollowerIntegrationTest/Build___JDK_20_and_Scala_2_13___testRackAwareRangeAssignor__/)
[Build / JDK 20 and Scala 2.13 / kafka.server.KRaftClusterTest.testIncrementalAlterConfigs()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.server/KRaftClusterTest/Build___JDK_20_and_Scala_2_13___testIncrementalAlterConfigs__/)
[Build / JDK 20 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testFenceMultipleBrokers()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/org.apache.kafka.controller/QuorumControllerTest/Build___JDK_20_and_Scala_2_13___testFenceMultipleBrokers__/)
[Build / JDK 20 and Scala 2.13 / org.apache.kafka.controller.QuorumControllerTest.testBalancePartitionLeaders()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/org.apache.kafka.controller/QuorumControllerTest/Build___JDK_20_and_Scala_2_13___testBalancePartitionLeaders__/)
[Build / JDK 17 and Scala 2.13 / kafka.server.KRaftClusterTest.testIncrementalAlterConfigs()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.server/KRaftClusterTest/Build___JDK_17_and_Scala_2_13___testIncrementalAlterConfigs__/)
[Build / JDK 17 and Scala 2.13 / kafka.server.KRaftClusterTest.testIncrementalAlterConfigs()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/kafka.server/KRaftClusterTest/Build___JDK_17_and_Scala_2_13___testIncrementalAlterConfigs___2/)
[Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindReplicationFlow()](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/org.apache.kafka.connect.mirror.integration/MirrorConnectorsIntegrationExactlyOnceTest/Build___JDK_8_and_Scala_2_12___testOffsetTranslationBehindReplicationFlow__/)
[Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest.testConnectorBoundary](https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13962/1/testReport/junit/org.apache.kafka.connect.integration/ExactlyOnceSourceIntegrationTest/Build___JDK_8_and_Scala_2_12___testConnectorBoundary/)

@divijvaidya divijvaidya merged commit 1d8b07e into apache:trunk Jul 7, 2023
@hudeqi hudeqi deleted the clean_metric_coordinator branch July 7, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants