KAFKA-14734: Use CommandDefaultOptions in StreamsResetter

[fvaleri]

This PR adds CommandDefaultOptions usage like in the other joptsimple based tools. It also moves the associated unit test class from streams to tools module as discussed in #13127 (comment).

[showuon]

LGTM! Thanks for the patch!

[showuon]

@vamossagar12 , do you have time to have a look?

[vamossagar12]

@showuon , I will take a look today.

[vamossagar12]

minor nit changes. LGTM otherwise. Also, thanks for picking the tests migration!

[showuon]

Failed tests are unrelated:

Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindReplicationFlow()
Build / JDK 17 and Scala 2.13 / org.apache.kafka.tools.MetadataQuorumCommandTest.[1] Type=Raft-Combined, Name=testDescribeQuorumReplicationSuccessful, MetadataVersion=3.6-IV0, Security=PLAINTEXT
Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testReplication()
Build / JDK 8 and Scala 2.12 / org.apache.kafka.controller.QuorumControllerTest.testBalancePartitionLeaders()
Build / JDK 20 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindReplicationFlow()
Build / JDK 20 and Scala 2.13 / org.apache.kafka.trogdor.coordinator.CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated()
Build / JDK 11 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehindReplicationFlow()

[mjsax]

Just discovered this PR -- Seems it part of KIP-906, but the KIP does not cover the renaming of the method -- it's technically a breaking change...

Given that StreamsResetter is marked as @InterfaceStability.Unstable it might be ok without a deprecation phase of the old method, but the KIP should mention it. Can we get the KIP updated accordingly?

\cc @cadonna who commented on the other PR.

[fvaleri]

Hi @mjsax, I'm sorry if this caused any issue, but the intention was to give some some consistency to how these tools are structured, whenever possible. This is not part of KIP-906, but simply in the context of KAFKA-14525.

[cadonna]

@mjsax @fvaleri The javadocs of the StreamsResetter say:

This class is not part of public API. For backward compatibility, use the provided script in "bin/" instead of calling this class directly from your code.

See

kafka/tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java

Line 65 in 334c41d

* <strong>This class is not part of public API. For backward compatibility,

I think we do not need to do anything.

[mjsax]

Not a big deal -- as StreamsResetter is not public API, we don't need a deprecation period. I was just trying to say, because StreamsResetter is "semi-public" it might be nice to mention the renaming without deprecation period in the KIP, for documentation purpose. Just a suggestion.