MINOR: Fix Javadocs for SourceTaskContext::transactionContext and SinkTaskContext::errantRecordReporter to use NoSuchMethodError instead of NoSuchMethodException#14036
Merged
gharris1727 merged 1 commit intoapache:trunkfrom Jul 19, 2023
Conversation
Contributor
Author
|
Hi @gharris1727, I noticed this small discrepancy after our related discussion here. Could you please take a look whenever you get a chance? |
…kTaskContext::errantRecordReporter to use NoSuchMethodError instead of NoSuchMethodException
d59d913 to
174dc93
Compare
gharris1727
approved these changes
Jul 19, 2023
Contributor
gharris1727
left a comment
There was a problem hiding this comment.
Thanks for the fix! I like that the code sample is correct but the Javadoc is wrong :)
It also looks like there's no other similar mistakes.
LGTM!
Contributor
Author
|
Thanks Greg! |
jeqo
pushed a commit
to jeqo/kafka
that referenced
this pull request
Jul 21, 2023
…stead of NoSuchMethodException (apache#14036) Reviewed-by: Greg Harris <greg.harris@aiven.io>
Cerchie
pushed a commit
to Cerchie/kafka
that referenced
this pull request
Jul 25, 2023
…stead of NoSuchMethodException (apache#14036) Reviewed-by: Greg Harris <greg.harris@aiven.io>
jeqo
pushed a commit
to aiven/kafka
that referenced
this pull request
Aug 15, 2023
…stead of NoSuchMethodException (apache#14036) Reviewed-by: Greg Harris <greg.harris@aiven.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoSuchMethodErroris thrown if an application tries to call a specified method of a class (either static or instance), and that class no longer has a definition of that method. Normally, this error is caught by the compiler; this error can only occur at run time if the definition of a class has incompatibly changed.NoSuchMethodExceptionis thrown when trying to reflectively access a method that does not exist.SourceTaskContext::transactionContextandSinkTaskContext::errantRecordReportermethods useNoSuchMethodErrorin the example code block (which is the correctThrowableto use in this situation) but incorrectly specifyNoSuchMethodExceptionin their Javadocs.kafka/connect/api/src/main/java/org/apache/kafka/connect/sink/SinkTaskContext.java
Lines 110 to 117 in a1f6ab6
kafka/connect/api/src/main/java/org/apache/kafka/connect/source/SourceTaskContext.java
Lines 51 to 58 in a1f6ab6
Committer Checklist (excluded from commit message)