KAFKA-15248 Add BooleanConverter#14093
Conversation
yashmayya
left a comment
There was a problem hiding this comment.
Thanks @hgeraldino, I just had a couple of minor comments.
|
Thanks @yashmayya for your review! I addressed your comments, please take another look when you have a chance |
yashmayya
left a comment
There was a problem hiding this comment.
Thanks @hgeraldino, LGTM! I just had a few more minor suggestions.
Addressed the second round of comments. Thanks again! |
vamossagar12
left a comment
There was a problem hiding this comment.
I just have a small question. Other than that LGTM
|
@hgeraldino the Connect integration tests are failing with errors like: This is related to KIP-898 and specifically changes that were made in #14055. Could you please update the Converter and HeaderConverter provider-configuration files to include the new |
…ers/BooleanConverter.java Co-authored-by: Yash Mayya <yash.mayya@gmail.com>
…ers/BooleanConverterTest.java Co-authored-by: Yash Mayya <yash.mayya@gmail.com>
b3339c7 to
50445bc
Compare
Thanks @yashmayya, adding entries for the new converter to the metadata fixed the build issues 👍 |
d486534 to
698adb4
Compare
yashmayya
left a comment
There was a problem hiding this comment.
Thanks for the updates @hgeraldino, the build looks good now. My apologies for not noticing these earlier, but I just had a couple more minor comments. This should be good to be merged once they're addressed. Thanks for your continued patience!
Addressed both comments, good catch! |
yashmayya
left a comment
There was a problem hiding this comment.
Thanks @hgeraldino, LGTM!
|
The test failures are all unrelated and pass on rerun locally: Merging to trunk. |
…14093) Reviewers: Yash Mayya <yash.mayya@gmail.com>, Sagar Rao <sagarmeansocean@gmail.com>, Qichao Chu <5326144+ex172000@users.noreply.github.com>
…14093) Reviewers: Yash Mayya <yash.mayya@gmail.com>, Sagar Rao <sagarmeansocean@gmail.com>, Qichao Chu <5326144+ex172000@users.noreply.github.com>
…14093) Reviewers: Yash Mayya <yash.mayya@gmail.com>, Sagar Rao <sagarmeansocean@gmail.com>, Qichao Chu <5326144+ex172000@users.noreply.github.com>
JIRA: KAFKA-15248
KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-959%3A+Add+BooleanConverter+to+Kafka+Connect
Committer Checklist (excluded from commit message)