MINOR: Permit tombstone offsets with any partition for file source connector#14233
Closed
C0urante wants to merge 1 commit intoapache:trunkfrom
Closed
MINOR: Permit tombstone offsets with any partition for file source connector#14233C0urante wants to merge 1 commit intoapache:trunkfrom
C0urante wants to merge 1 commit intoapache:trunkfrom
Conversation
3 tasks
Contributor
Author
|
Closing in favor of #14234 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aligns the behavior of the file and MM2 source connectors with regards to tombstone offsets submitted via the REST API. Partition validation is intentionally disabled for tombstone offsets to allow users to clean up the offsets topic in case there's garbage in there, which may come from previous connectors with the same name but a different type, or newer versions of the connector that aren't compatible with the current version after an upgrade is reverted.
See #14005 for the PR that introduced this logic to MM2.
Committer Checklist (excluded from commit message)