Skip to content

MINOR: Fix NPE in controllerListeners from controller server#14394

Closed
dengziming wants to merge 1 commit intoapache:trunkfrom
dengziming:nep-Listener
Closed

MINOR: Fix NPE in controllerListeners from controller server#14394
dengziming wants to merge 1 commit intoapache:trunkfrom
dengziming:nep-Listener

Conversation

@dengziming
Copy link
Copy Markdown
Member

@dengziming dengziming commented Sep 18, 2023

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

We can't start controller server if host is not set manually, this is similar to #10575.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dengziming dengziming changed the title MINOR: Fix NPE in networkListeners from controller server MINOR: Fix NPE in controllerListeners from controller server Sep 18, 2023
@dengziming
Copy link
Copy Markdown
Member Author

This bug is introduced from #14306 , ping @cmccabe and @showuon to have a look.

@showuon
Copy link
Copy Markdown
Member

showuon commented Sep 19, 2023

Will take a look this week.

@dengziming
Copy link
Copy Markdown
Member Author

already fixed.

@dengziming dengziming closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants