HOTIFX: fix Kafka versions for system tests#14490
Conversation
|
|
||
| DEV_BRANCH = KafkaVersion("dev") | ||
| DEV_VERSION = KafkaVersion("3.6.0-SNAPSHOT") | ||
| DEV_VERSION = KafkaVersion("3.7.0-SNAPSHOT") |
There was a problem hiding this comment.
forgot to dump the dev-version -- this breaks the system test setup.
There was a problem hiding this comment.
This may be just bad timing as @satishd is releasing 3.6.0 right now. We typically bump this version after the vote passes according to the release process: https://cwiki.apache.org/confluence/display/KAFKA/Release+Process#ReleaseProcess-Afterthevotepasses
I wonder if we should undo this change from this PR and let Satish do it as part of the release process. WDYT?
There was a problem hiding this comment.
| # 3.7.x versions | ||
| V_3_7_0 = KafkaVersion("3.7.0") | ||
| LATEST_3_7 = V_3_7_0 No newline at end of file | ||
| # only add released versions here No newline at end of file |
There was a problem hiding this comment.
Side cleanup -- happens all the time -- added a comment now -- we only add released versions here. There is no 3.7.0 release yet -- seems even 3.6.0 was added pre-mature -- your PR bumping the versions should have added 3.6.0...
There was a problem hiding this comment.
Thanks for adding this comment. It will clarify for other RMs or whoever is making the required changes for the release.
| DEV_VERSION = KafkaVersion("3.6.0-SNAPSHOT") | ||
| DEV_VERSION = KafkaVersion("3.7.0-SNAPSHOT") | ||
|
|
||
| LATEST_METADATA_VERSION = "3.6" |
There was a problem hiding this comment.
Not sure what this is -- does it need to be bumped or not?
|
Found a similar issue for 2.6 branch -> #14492 |
|
Also 2.7 -> #14493 |
|
2.8 is not broken, but needs some version bumps -> #14494 |
|
3.0 is also broken -> #14495 |
|
3.1 is broken, too: #14496 |
|
3.2 -> #14497 |
|
3.3 -> #14498 |
|
3.4 is ok, just needs a few versions bumps: #14499 |
|
3.5 is broken as well: #14500 |
|
3.6 is fine, but also needs some version bumps: #14501 |
| # 3.7.x versions | ||
| V_3_7_0 = KafkaVersion("3.7.0") | ||
| LATEST_3_7 = V_3_7_0 No newline at end of file | ||
| # only add released versions here No newline at end of file |
There was a problem hiding this comment.
Thanks for adding this comment. It will clarify for other RMs or whoever is making the required changes for the release.
Reviewers: Luke Chen <showuon@gmail.com>, Satish Duggana <satishd@apache.org>
Reviewers: Luke Chen <showuon@gmail.com>, Satish Duggana <satishd@apache.org>
4 participants
The last PR (9e3b1f9) bumping versions introduces a bug for system test setup. This PR fixes it.
Call for review @satishd