Skip to content

KAFKA-15593: Add 3.6 to core upgrade and compatibility tests#14527

Merged
satishd merged 2 commits intoapache:trunkfrom
satishd:KAFKA-15576-core
Oct 13, 2023
Merged

KAFKA-15593: Add 3.6 to core upgrade and compatibility tests#14527
satishd merged 2 commits intoapache:trunkfrom
satishd:KAFKA-15576-core

Conversation

@satishd
Copy link
Copy Markdown
Member

@satishd satishd commented Oct 11, 2023

This is part of the 3.6.0 release process as mentioned here.

For feature releases, file a JIRA for updating compatibility/upgrade system tests to test the newly released version. 

This PR is only related to core upgrade and compatibility related tests.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Copy Markdown
Contributor

@clolov clolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you!

Copy link
Copy Markdown
Contributor

@jlprat jlprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @satishd LGTM
I just have a nitpick about parenthesis on import only being present on one of the files

from kafkatest.tests.produce_consume_validate import ProduceConsumeValidateTest
from kafkatest.utils import is_int
from kafkatest.version import LATEST_0_8_2, LATEST_0_9, LATEST_0_10_0, LATEST_0_10_1, LATEST_0_10_2, LATEST_0_11_0, \
from kafkatest.version import (LATEST_0_8_2, LATEST_0_9, LATEST_0_10_0, LATEST_0_10_1, LATEST_0_10_2, LATEST_0_11_0, \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the new parens, and only in this file and not in the others?

@jlprat
Copy link
Copy Markdown
Contributor

jlprat commented Oct 11, 2023

I restarted the jenkins job as lots of tests failed at the initialization step

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Oct 11, 2023

Seems this does not cover KS -- btw: there is some issue for KS system tests right now, and as a matter of fact, we did not even add the missing upgrade tests in older release yet (PR is still pending).

I am ok with merging this PR, but we should not close the JIRA until everything is resolved IMHO.

@satishd satishd changed the title KAFKA-15576: Add 3.6 to core upgrade and compatibility tests KAFKA-15593: Add 3.6 to core upgrade and compatibility tests Oct 12, 2023
@satishd
Copy link
Copy Markdown
Member Author

satishd commented Oct 12, 2023

Seems this does not cover KS -- btw: there is some issue for KS system tests right now, and as a matter of fact, we did not even add the missing upgrade tests in older release yet (PR is still pending).

Right, this change is related to core upgrade and compatibility tests. Updated the PR description for clarity. I saw that KS related updates for earlier releases are in progress as part of #13860

I am ok with merging this PR, but we should not close the JIRA until everything is resolved IMHO.

Sure, created two separate sub tasks on KAFKA-15576 for tracking them separately and close the parent JIRA once both the sub tasks are resolved.

@satishd satishd merged commit cc951e3 into apache:trunk Oct 13, 2023
AnatolyPopov pushed a commit to aiven/kafka that referenced this pull request Feb 16, 2024
…14527)

Reviewers:  Christo Lolov <lolovc@amazon.com>, Josep Prat <josep.prat@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants