Skip to content

KAFKA-15093: Add 3.5 Streams upgrade system tests #14602

Merged
mimaison merged 1 commit intoapache:trunkfrom
mimaison:kafka-15093
Oct 23, 2023
Merged

KAFKA-15093: Add 3.5 Streams upgrade system tests #14602
mimaison merged 1 commit intoapache:trunkfrom
mimaison:kafka-15093

Conversation

@mimaison
Copy link
Copy Markdown
Member

Extracted the 3.5 changes from #13860

Only merge this PR after #14601 is merged

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@mjsax mjsax added streams tests Test fixes (including flaky tests) labels Oct 23, 2023
@mimaison mimaison marked this pull request as ready for review October 23, 2023 09:26
@mimaison mimaison merged commit 8b9f6d1 into apache:trunk Oct 23, 2023
@mimaison mimaison deleted the kafka-15093 branch October 23, 2023 11:27
mimaison added a commit that referenced this pull request Oct 23, 2023
Reviewers: Matthias J. Sax <mjsax@apache.org>
mimaison added a commit that referenced this pull request Oct 23, 2023
Reviewers: Matthias J. Sax <mjsax@apache.org>
@mimaison
Copy link
Copy Markdown
Member Author

Backported to 3.5 and 3.6

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Oct 23, 2023

Why backport to 3.5 ? That's not necessary -- we test upgrade to DEV_VERSION what is 3.5.x-SNAPSHOT -- no need to double test.

@mimaison
Copy link
Copy Markdown
Member Author

Are we ok keeping the commit or should we revert it?

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Oct 23, 2023

I think it would be good to revert? System test run already very long, and if we can cut down a few minutes by not re-running the same test twice, it might be good?

@mimaison
Copy link
Copy Markdown
Member Author

Ok, I'll revert d769f1d in the 3.5 branch.

mimaison added a commit that referenced this pull request Oct 23, 2023
This reverts commit d769f1d.
It is not needed to explictly add 3.5 as the system tests automatically attempt upgrades to DEV_VERSION which is 3.5.x-SNAPSHOT in this branch.
@mimaison
Copy link
Copy Markdown
Member Author

Done

mjsax pushed a commit to confluentinc/kafka that referenced this pull request Nov 22, 2023
Reviewers: Matthias J. Sax <mjsax@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

streams tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants