KAFKA-15276: Implement event plumbing for ConsumerRebalanceListener callbacks#14640
Merged
dajac merged 85 commits intoapache:trunkfrom Dec 15, 2023
kirktrue:KAFKA-15276-partition-reconciliation
Merged
KAFKA-15276: Implement event plumbing for ConsumerRebalanceListener callbacks#14640dajac merged 85 commits intoapache:trunkfrom kirktrue:KAFKA-15276-partition-reconciliation
dajac merged 85 commits intoapache:trunkfrom
kirktrue:KAFKA-15276-partition-reconciliation
Conversation
Added logic for reconciling partition assignment between the target assignment provided by the group coordinator and the current assignment as specified in the SubscriptionState. This refactors the ConsumerRebalanceListener code from ConsumerCoordinator for reuse in both places.
…ication event handler
Contributor
Author
|
@philipnee Can you add the |
philipnee
added
the
KIP-848
…n-reconciliation
kirktrue
changed the title
…OnPartitionsRevoked()
…sts for the consumer group protocol
…partitionsFor is implemented
Member
|
@kirktrue The last build has compilation errors. Could you please check? |
Contributor
Author
Fixed. Oddly I couldn't get it to break locally until I re-sync'ed my fork and merged in |
Contributor
Author
|
Build failed because code couldn't be |
Contributor
Author
|
Build failed yet again because code couldn't be |
Contributor
Author
|
Closing and reopening due to Jenkins fussiness:
|
dajac
pushed a commit
that referenced
this pull request
Dec 15, 2023
…allbacks (#14640) This patch adds the logic for coordinating the invocation of the `ConsumerRebalanceListener` callback invocations between the background thread (in `MembershipManagerImpl`) and the application thread (`AsyncKafkaConsumer`) and back again. It allowed us to enable more tests from `PlaintextConsumerTest` to exercise the code herein. Reviewers: David Jacot <djacot@confluent.io>
Member
|
The failed tests are not related. Merged it to trunk and 3.7. |
gaurav-narula
pushed a commit
to gaurav-narula/kafka
that referenced
this pull request
Jan 24, 2024
…allbacks (apache#14640) This patch adds the logic for coordinating the invocation of the `ConsumerRebalanceListener` callback invocations between the background thread (in `MembershipManagerImpl`) and the application thread (`AsyncKafkaConsumer`) and back again. It allowed us to enable more tests from `PlaintextConsumerTest` to exercise the code herein. Reviewers: David Jacot <djacot@confluent.io>
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
…allbacks (apache#14640) This patch adds the logic for coordinating the invocation of the `ConsumerRebalanceListener` callback invocations between the background thread (in `MembershipManagerImpl`) and the application thread (`AsyncKafkaConsumer`) and back again. It allowed us to enable more tests from `PlaintextConsumerTest` to exercise the code herein. Reviewers: David Jacot <djacot@confluent.io>
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Feb 16, 2024
…allbacks (apache#14640) This patch adds the logic for coordinating the invocation of the `ConsumerRebalanceListener` callback invocations between the background thread (in `MembershipManagerImpl`) and the application thread (`AsyncKafkaConsumer`) and back again. It allowed us to enable more tests from `PlaintextConsumerTest` to exercise the code herein. Reviewers: David Jacot <djacot@confluent.io>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
…allbacks (apache#14640) This patch adds the logic for coordinating the invocation of the `ConsumerRebalanceListener` callback invocations between the background thread (in `MembershipManagerImpl`) and the application thread (`AsyncKafkaConsumer`) and back again. It allowed us to enable more tests from `PlaintextConsumerTest` to exercise the code herein. Reviewers: David Jacot <djacot@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added logic for coordinating the invocation of the
ConsumerRebalanceListenercallback invocations between the background thread (inMembershipManagerImpl) and the application thread (AsyncKafkaConsumer) and back again.This allowed us to enable more tests from
PlaintextConsumerTestto exercise the code herein.