KAFKA-2203: Getting Java8 to relax about javadoc and let our build pass#147
Closed
gwenshap wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-2203: Getting Java8 to relax about javadoc and let our build pass#147gwenshap wants to merge 1 commit intoapache:trunkfrom
gwenshap wants to merge 1 commit intoapache:trunkfrom
Conversation
Contributor
Author
|
Note that without this patch, "./gradlew install" fails with Java8 |
Member
|
LGTM, |
|
kafka-trunk-git-pr #165 FAILURE |
Contributor
Author
|
The test failure seems unrelated. @guozhangwang, @junrao - I need a commit :) |
Contributor
|
LGTM, thanks. |
apurvam
pushed a commit
to apurvam/kafka
that referenced
this pull request
Apr 3, 2017
* handling add offsets to txn * add a pending state with prepareTransition / completeTransaction / abortTransition of state * refactor handling logic for multiple in-flight requests
dguy
pushed a commit
to dguy/kafka
that referenced
this pull request
Apr 13, 2017
* handling add offsets to txn * add a pending state with prepareTransition / completeTransaction / abortTransition of state * refactor handling logic for multiple in-flight requests
davide-armand
pushed a commit
to aiven/kafka
that referenced
this pull request
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is different than the one attached to the JIRA - I'm applying the new javadoc rules to all subprojects while the one in the JIRA applies only to "clients". We need this since Copycat has the same issues.