Revert "KAFKA-15764: Missing Tests for Transactions (#14702)"#15029
Merged
lucasbru merged 1 commit intoapache:trunkfrom Dec 18, 2023
Merged
Revert "KAFKA-15764: Missing Tests for Transactions (#14702)"#15029lucasbru merged 1 commit intoapache:trunkfrom
lucasbru merged 1 commit intoapache:trunkfrom
Conversation
This reverts commit ed7ad6d.
This was referenced Dec 17, 2023
cadonna
approved these changes
Dec 18, 2023
Member
cadonna
left a comment
cadonna
left a comment
There was a problem hiding this comment.
and this looks quite suspicious.
Let's revert this.
Member
|
\cc @jolshan |
Member
|
Hmm. My test utils change set the default compression setting so it is surprising that something should change. |
Member
|
Seems like the issue was only with the tiered store test? And with the compression enabled. I wonder if there is something weird about tiered storage not allowing compression. |
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
…pache#15029) This reverts commit ed7ad6d. We have been seeing a lot of failures of TransactionsWithTieredStoreTest.testTransactionsWithCompression on trunk, and it seems to start with this PR. I see how this PR can influence the test via the change in TestUtils. The bad part is that sometimes seems to kill the Gradle Executors completely. So I'd suggest reverting the change before investigating further to stabilize CI. Reviewers: Bruno Cadonna <cadonna@apache.org>
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Feb 16, 2024
…pache#15029) This reverts commit ed7ad6d. We have been seeing a lot of failures of TransactionsWithTieredStoreTest.testTransactionsWithCompression on trunk, and it seems to start with this PR. I see how this PR can influence the test via the change in TestUtils. The bad part is that sometimes seems to kill the Gradle Executors completely. So I'd suggest reverting the change before investigating further to stabilize CI. Reviewers: Bruno Cadonna <cadonna@apache.org>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
…pache#15029) This reverts commit ed7ad6d. We have been seeing a lot of failures of TransactionsWithTieredStoreTest.testTransactionsWithCompression on trunk, and it seems to start with this PR. I see how this PR can influence the test via the change in TestUtils. The bad part is that sometimes seems to kill the Gradle Executors completely. So I'd suggest reverting the change before investigating further to stabilize CI. Reviewers: Bruno Cadonna <cadonna@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit ed7ad6d.
We have been seeing a lot of failures of
TransactionsWithTieredStoreTest.testTransactionsWithCompressionon trunk, and it seems to start with this PR. I see how this PR can influence the test via the change inTestUtils. The bad part is that sometimes seems to kill the Gradle Executors completely. So I'd suggest reverting the change before investigating further to stabilize CI.Committer Checklist (excluded from commit message)