KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders#15139
Merged
jolshan merged 10 commits intoapache:trunkfrom Jan 23, 2024
Merged
KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders#15139jolshan merged 10 commits intoapache:trunkfrom
jolshan merged 10 commits intoapache:trunkfrom
Conversation
3 tasks
jsancio
reviewed
Jan 13, 2024
Member
jsancio
left a comment
jsancio
left a comment
There was a problem hiding this comment.
Thanks. One minor suggestion.
| files="(QuorumController).java"/> | ||
| <suppress checks="(CyclomaticComplexity|NPathComplexity)" | ||
| files="(PartitionRegistration|PartitionChangeBuilder).java"/> | ||
| files="(PartitionRegistration|PartitionChangeBuilder|TopicDelta).java"/> |
Member
There was a problem hiding this comment.
Did you try changing the code so that it doesn't warn you of path complexity? If it is not possible can you use annotations instead? I added annotation support a while back. Checkout: https://lists.apache.org/thread/mjxfofn823o1ozrzo36ogj17xmlrxod9
Member
Author
There was a problem hiding this comment.
In between when I wrote this originally and now a lot of JBOD code was added. I don't think I have the skills to make it simpler. I don't think there is a way to change my code. I can use the annotation if you think that keeps the suppression more contained
Member
There was a problem hiding this comment.
Yes. Let's use annotation so that it only applies to the methods that violates our coding style.
jsancio
approved these changes
Jan 22, 2024
Member
jsancio
left a comment
jsancio
left a comment
There was a problem hiding this comment.
LGTM. Feel free to merge if the tests are green.
3 tasks
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
… loaded leaders (apache#15139) This originally was apache#14489 which covered 2 aspects -- reloading on partition epoch changes where leader epoch did not change and reloading when leader epoch changed but we were already the leader. I've cut out the second part of the change since the first part is much simpler. Redefining the TopicDelta fields to better distinguish when a leader is elected (leader epoch bump) vs when a leader has isr/replica changes (partition epoch bump). There are some cases where we bump the partition epoch but not the leader epoch. We do not need to do operations that only care about the leader epoch bump. (ie -- onElect callbacks) Reviewers: Artem Livshits <alivshits@confluent.io>, José Armando García Sancio <jsancio@apache.org>
3 tasks
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
… loaded leaders (apache#15139) This originally was apache#14489 which covered 2 aspects -- reloading on partition epoch changes where leader epoch did not change and reloading when leader epoch changed but we were already the leader. I've cut out the second part of the change since the first part is much simpler. Redefining the TopicDelta fields to better distinguish when a leader is elected (leader epoch bump) vs when a leader has isr/replica changes (partition epoch bump). There are some cases where we bump the partition epoch but not the leader epoch. We do not need to do operations that only care about the leader epoch bump. (ie -- onElect callbacks) Reviewers: Artem Livshits <alivshits@confluent.io>, José Armando García Sancio <jsancio@apache.org>
Phuc-Hong-Tran
pushed a commit
to Phuc-Hong-Tran/kafka
that referenced
this pull request
Jun 6, 2024
… loaded leaders (apache#15139) This originally was apache#14489 which covered 2 aspects -- reloading on partition epoch changes where leader epoch did not change and reloading when leader epoch changed but we were already the leader. I've cut out the second part of the change since the first part is much simpler. Redefining the TopicDelta fields to better distinguish when a leader is elected (leader epoch bump) vs when a leader has isr/replica changes (partition epoch bump). There are some cases where we bump the partition epoch but not the leader epoch. We do not need to do operations that only care about the leader epoch bump. (ie -- onElect callbacks) Reviewers: Artem Livshits <alivshits@confluent.io>, José Armando García Sancio <jsancio@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This originally was #14489 which covered 2 aspects -- reloading on partition epoch changes where leader epoch did not change and reloading when leader epoch changed but we were already the leader.
I've cut out the second part of the change since the first part is much simpler.
Redefining the TopicDelta fields to better distinguish when a leader is elected (leader epoch bump) vs when a leader has isr/replica changes (partition epoch bump). There are some cases where we bump the partition epoch but not the leader epoch. We do not need to do operations that only care about the leader epoch bump. (ie -- onElect callbacks)