KAFKA-14505; [4/N] Wire transaction verification#15142
Merged
dajac merged 8 commits intoapache:trunkfrom Jan 11, 2024
Merged
Conversation
Member
|
Yup -- sorry was hoping to do all the clean ups before you got to this -- but shouldn't be too hard to update. |
jolshan
reviewed
Jan 8, 2024
jolshan
reviewed
Jan 8, 2024
jolshan
reviewed
Jan 8, 2024
jolshan
reviewed
Jan 8, 2024
Member
Author
jolshan
reviewed
Jan 10, 2024
jolshan
approved these changes
Jan 10, 2024
Member
jolshan
left a comment
jolshan
left a comment
There was a problem hiding this comment.
Not sure if you meant to push the change to link the interface docs, but once that is complete LGTM.
showuon
pushed a commit
to showuon/kafka
that referenced
this pull request
Jan 22, 2024
This patch wires the transaction verification in the new group coordinator. It basically calls the verification path before scheduling the write operation. If the verification fails, the error is returned to the caller. Note that the patch uses `appendForGroup`. I suppose that we will move away from using it when apache#15087 is merged. Reviewers: Justine Olshan <jolshan@confluent.io>
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
This patch wires the transaction verification in the new group coordinator. It basically calls the verification path before scheduling the write operation. If the verification fails, the error is returned to the caller. Note that the patch uses `appendForGroup`. I suppose that we will move away from using it when apache#15087 is merged. Reviewers: Justine Olshan <jolshan@confluent.io>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
This patch wires the transaction verification in the new group coordinator. It basically calls the verification path before scheduling the write operation. If the verification fails, the error is returned to the caller. Note that the patch uses `appendForGroup`. I suppose that we will move away from using it when apache#15087 is merged. Reviewers: Justine Olshan <jolshan@confluent.io>
Phuc-Hong-Tran
pushed a commit
to Phuc-Hong-Tran/kafka
that referenced
this pull request
Jun 6, 2024
This patch wires the transaction verification in the new group coordinator. It basically calls the verification path before scheduling the write operation. If the verification fails, the error is returned to the caller. Note that the patch uses `appendForGroup`. I suppose that we will move away from using it when apache#15087 is merged. Reviewers: Justine Olshan <jolshan@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch wires the transaction verification in the new group coordinator. It basically calls the verification path before scheduling the write operation. If the verification fails, the error is returned to the caller.
Note that the patch uses
appendForGroup. I suppose that we will move away from using it when #15087 is merged.Committer Checklist (excluded from commit message)