KAFKA-15834: Remove more leaky NamedTopologyIntegrationTest tests#15243
Merged
gharris1727 merged 2 commits intoapache:trunkfrom Feb 5, 2024
Merged
Conversation
… that contain resource leaks Signed-off-by: Greg Harris <greg.harris@aiven.io>
Contributor
Author
|
Hey @ableegoldman I missed some of the tests in this suite, so I had to open a follow-up. Thanks! |
3 tasks
Signed-off-by: Greg Harris <greg.harris@aiven.io>
f13d8df to
c45345f
Compare
Contributor
Author
|
Test failures appear unrelated. |
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
…ache#15243) Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Anna Sophie Blee-Goldman <sophie@responsive.dev>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
…ache#15243) Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Anna Sophie Blee-Goldman <sophie@responsive.dev>
Phuc-Hong-Tran
pushed a commit
to Phuc-Hong-Tran/kafka
that referenced
this pull request
Jun 6, 2024
…ache#15243) Signed-off-by: Greg Harris <greg.harris@aiven.io> Reviewers: Anna Sophie Blee-Goldman <sophie@responsive.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests leak resources intermittently, so I didn't catch them in #15185:
I haven't observed the other tests in this suite fail, but that doesn't mean they don't have leaks.
The leaks do all seem to follow the same pattern: the close(Duration) calls time out, leaving behind resources. You can see these failures in #14783.
Committer Checklist (excluded from commit message)