MINOR: Clean up core server classes#15272
Merged
jlprat merged 2 commits intoapache:trunkfrom Jan 31, 2024
Merged
Conversation
jlprat
commented
Jan 26, 2024
| case Some(partition) => | ||
| if (!partition.replicas.contains(brokerId)) { | ||
| info(s"Found stray log dir $log: the current replica assignment ${partition.replicas} " + | ||
| info(s"Found stray log dir $log: the current replica assignment ${partition.replicas.mkString("Array(", ", ", ")")} " + |
Contributor
Author
There was a problem hiding this comment.
This actually should have printed the memory reference and not the contents. With the current version, it prints the contents.
| val configProps = conf.dynamicConfig.fromPersistentProps(persistentProps, perBrokerConfig) | ||
| val alterConfigOps = resource.configs().asScala.map { | ||
| case config => | ||
| config => |
Contributor
Author
There was a problem hiding this comment.
Previous code was the standard in really old version of Scala, since then anonymous function style is preferred.
| ): AlterConfigsResponseData = { | ||
| val response = new AlterConfigsResponseData() | ||
| val responsesByResource = persistentResponses.responses().iterator().asScala.map { | ||
| case r => (r.resourceName(), r.resourceType()) -> new ApiError(r.errorCode(), r.errorMessage()) |
Contributor
Author
There was a problem hiding this comment.
Previous code was the standard in really old version of Scala, since then anonymous function style is preferred.
| def describeConfigs(resourceToConfigNames: List[DescribeConfigsResource], | ||
| includeSynonyms: Boolean, | ||
| includeDocumentation: Boolean): List[DescribeConfigsResponseData.DescribeConfigsResult] = { | ||
| resourceToConfigNames.map { case resource => |
Contributor
Author
There was a problem hiding this comment.
Previous code was the standard in really old version of Scala, since then anonymous function style is preferred.
| } | ||
| quotaDelta.changes().entrySet().forEach { e => | ||
| handleUserClientQuotaChange(userClientEntity, e.getKey, e.getValue.asScala.map(_.toDouble)) | ||
| handleUserClientQuotaChange(userClientEntity, e.getKey, e.getValue.asScala) |
Contributor
Author
There was a problem hiding this comment.
The map to Double wasn't needed as it was already a double
Contributor
Author
|
@showuon if you have some time, this is a follow up of the one you reviewed already. |
mimaison
approved these changes
Jan 29, 2024
Member
mimaison
left a comment
mimaison
left a comment
There was a problem hiding this comment.
LGTM, pending a good CI result
jlprat
force-pushed
the
MINOR-cleanup-core-part2
branch
from
206fc68 to
96d67cd
Compare
Contributor
Author
|
Needed to rebase because of merge conflicts |
Mark methods and fields private where possible Annotate public methods and fields Remove unused classes and methods Make sure Arrays are not printed with .toString Optimize minor warnings
Signed-off-by: Josep Prat <josep.prat@aiven.io>
jlprat
force-pushed
the
MINOR-cleanup-core-part2
branch
from
96d67cd to
7f08216
Compare
Contributor
Author
|
Rebased again to contain #15290 |
Contributor
Author
|
I checked that all tests pass locally, and the failures in CI seem all unrelated to the changes. |
yyu1993
pushed a commit
to yyu1993/kafka
that referenced
this pull request
Feb 15, 2024
* MINOR: Clean up core server classes Mark methods and fields private where possible Annotate public methods and fields Remove unused classes and methods Make sure Arrays are not printed with .toString Optimize minor warnings Remove unused apply method Signed-off-by: Josep Prat <josep.prat@aiven.io> Reviewers: Mickael Maison <mickael.maison@gmail.com>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
* MINOR: Clean up core server classes Mark methods and fields private where possible Annotate public methods and fields Remove unused classes and methods Make sure Arrays are not printed with .toString Optimize minor warnings Remove unused apply method Signed-off-by: Josep Prat <josep.prat@aiven.io> Reviewers: Mickael Maison <mickael.maison@gmail.com>
Phuc-Hong-Tran
pushed a commit
to Phuc-Hong-Tran/kafka
that referenced
this pull request
Jun 6, 2024
* MINOR: Clean up core server classes Mark methods and fields private where possible Annotate public methods and fields Remove unused classes and methods Make sure Arrays are not printed with .toString Optimize minor warnings Remove unused apply method Signed-off-by: Josep Prat <josep.prat@aiven.io> Reviewers: Mickael Maison <mickael.maison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #15252
Mark methods and fields private where possible:
Committer Checklist (excluded from commit message)