KAFKA-16671: enable test for ensureInternalEndpointIsSecured#15868
Merged
chia7712 merged 1 commit intoapache:trunkfrom May 15, 2024
Merged
Conversation
Member
|
@FrankYang0529 please fix the build error |
FrankYang0529
force-pushed
the
minor-test-ensureInternalEndpointIsSecured
branch
from
0cd6988 to
bf427fc
Compare
chia7712
reviewed
May 7, 2024
| ); | ||
| assertEquals( | ||
| FORBIDDEN.getStatusCode(), | ||
| SERVICE_UNAVAILABLE.getStatusCode(), |
Member
There was a problem hiding this comment.
Could you share the details with me?
Member
Author
There was a problem hiding this comment.
Here, if the connector is not started, there is no sessionKey.
Member
Author
There was a problem hiding this comment.
CI can't pass. Not sure whether there is some connector forgot to close. The error is:
java.lang.AssertionError: expected:<503> but was:<403>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotEquals(Assert.java:835)
at org.junit.Assert.assertEquals(Assert.java:647)
at org.junit.Assert.assertEquals(Assert.java:633)
at org.apache.kafka.connect.integration.SessionedProtocolIntegrationTest.ensureInternalEndpointIsSecured(SessionedProtocolIntegrationTest.java:118)
Member
There was a problem hiding this comment.
503 is a temporary error, because the worker is still in starting. Could you please add a wait to check the 503 first ?
Member
Author
There was a problem hiding this comment.
Added it and ensureInternalEndpointIsSecured can pass in CI environment. Thanks.
FrankYang0529
force-pushed
the
minor-test-ensureInternalEndpointIsSecured
branch
2 times, most recently
from
3b6345f to
8ea2054
Compare
FrankYang0529
changed the title
FrankYang0529
force-pushed
the
minor-test-ensureInternalEndpointIsSecured
branch
2 times, most recently
from
c8528eb to
71282b7
Compare
chia7712
reviewed
May 14, 2024
| assertEquals( | ||
| BAD_REQUEST.getStatusCode(), | ||
| connect.requestPost(connectorTasksEndpoint, "[]", emptyHeaders).getStatus() | ||
| BAD_REQUEST.getStatusCode(), |
Member
There was a problem hiding this comment.
please revert those unrelated changes
Member
Author
There was a problem hiding this comment.
Revert it. Thanks.
Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
minor-test-ensureInternalEndpointIsSecured
branch
from
71282b7 to
e0f1fba
Compare
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Jun 8, 2024
…5868) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
…5868) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related JIRA: https://issues.apache.org/jira/browse/KAFKA-16671
Enable the test to see error message. If there is any error, I will close this PR and investigate how to fix. If not, I will change the title to KAFKA-16671.
Committer Checklist (excluded from commit message)