[MINOR] : Code Cleanup - Misc modules#16067
Closed
sjhajharia wants to merge 1 commit intoapache:trunkfrom
Closed
Conversation
Closed
Member
|
@sjhajharia Could you please fix the conflicts |
Collaborator
Author
|
Thanks @chia7712 ! |
chia7712
reviewed
May 29, 2024
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@sjhajharia thanks for this cleanup. overall LGTM
| .setSecurityProtocol(SecurityProtocol.PLAINTEXT.id) | ||
| .setListener(plaintextListener.value()) | ||
| .setEndpoints(Collections.singletonList( | ||
| new UpdateMetadataRequestData.UpdateMetadataEndpoint() |
Member
There was a problem hiding this comment.
Could you please revert those unrelated changes to reduce the size of PR?
…ers (apache#16151) Use REQUEST_TIMEOUT_MS_CONFIG in AdminClient.fenceProducers, or options.timeoutMs if specified, as transaction timeout. No transaction will be started with this timeout, but ReplicaManager.appendRecords uses this value as its timeout. Use REQUEST_TIMEOUT_MS_CONFIG like a regular producer append to allow for replication to take place. Co-Authored-By: Adrian Preston <prestona@uk.ibm.com>
sjhajharia
force-pushed
the
misc-code-cleanup
branch
from
4ff2c41 to
e9f65e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Code Cleanup in Misc Modules
Changes
Some common changes include
Thanks!