KAFKA-16308 [2/N]: Allow unstable feature versions and rename unstable metadata config#16130
Merged
jolshan merged 3 commits intoapache:trunkfrom May 30, 2024
Merged
KAFKA-16308 [2/N]: Allow unstable feature versions and rename unstable metadata config#16130jolshan merged 3 commits intoapache:trunkfrom
jolshan merged 3 commits intoapache:trunkfrom
Conversation
3 tasks
dajac
reviewed
May 30, 2024
| // This indicates whether unreleased MetadataVersions should be enabled on this node. | ||
| .defineInternal(ServerConfigs.UNSTABLE_METADATA_VERSIONS_ENABLE_CONFIG, BOOLEAN, false, HIGH) | ||
| // This indicates whether unreleased MetadataVersions or other feature versions should be enabled on this node. | ||
| .defineInternal(ServerConfigs.UNSTABLE_FEATURE_VERSIONS_ENABLE_CONFIG, BOOLEAN, false, HIGH) |
Member
Author
There was a problem hiding this comment.
Yeah, it's a fair question. I think the original intent was to keep it internal and only use for testing.
Member
Author
There was a problem hiding this comment.
Yup -- this is the text in the KIP:
Add INTERNAL configuration unstable.feature.versions.enable to allow for non production ready features to be used (for testing)
junrao
reviewed
May 30, 2024
| */ | ||
| public FeatureVersion fromFeatureLevel(short level) { | ||
| public FeatureVersion fromFeatureLevel(short level, | ||
| boolean allowUnstableFeatureVersions) { |
Contributor
There was a problem hiding this comment.
Could we add the new param to javadoc?
| MetadataVersion.LATEST_PRODUCTION, | ||
| Map(TestFeatureVersion.FEATURE_NAME -> featureLevel), | ||
| allFeatures, | ||
| false, |
Contributor
There was a problem hiding this comment.
Hmm, TEST_VERSION level 2 is not in production and should show an exception when calling StorageTool.generateFeatureRecord?
Member
Author
There was a problem hiding this comment.
if (featureLevel <= Features.TEST_VERSION.defaultValue(MetadataVersion.LATEST_PRODUCTION)) this means we skip version 2
Member
Author
|
I filed https://issues.apache.org/jira/browse/KAFKA-16866 for the one failure and that is getting fixed separately. As for the others, looks like they are frequent flakes. I will go ahead and merge. |
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Jun 1, 2024
…e metadata config (apache#16130) As per KIP-1022, we will rename the unstable metadata versions enabled config to support all feature versions. Features is also updated to return latest production and latest testing versions of each feature. A feature is production ready when the corresponding metadata version (bootstrapMetadataVersion) is production ready. Adds tests for the feature usage of the unstableFeatureVersionsEnabled config Reviewers: David Jacot <djacot@confluent.io>, Jun Rao <junrao@gmail.com>
wernerdv
pushed a commit
to wernerdv/kafka
that referenced
this pull request
Jun 3, 2024
…e metadata config (apache#16130) As per KIP-1022, we will rename the unstable metadata versions enabled config to support all feature versions. Features is also updated to return latest production and latest testing versions of each feature. A feature is production ready when the corresponding metadata version (bootstrapMetadataVersion) is production ready. Adds tests for the feature usage of the unstableFeatureVersionsEnabled config Reviewers: David Jacot <djacot@confluent.io>, Jun Rao <junrao@gmail.com>
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Jun 8, 2024
…e metadata config (apache#16130) As per KIP-1022, we will rename the unstable metadata versions enabled config to support all feature versions. Features is also updated to return latest production and latest testing versions of each feature. A feature is production ready when the corresponding metadata version (bootstrapMetadataVersion) is production ready. Adds tests for the feature usage of the unstableFeatureVersionsEnabled config Reviewers: David Jacot <djacot@confluent.io>, Jun Rao <junrao@gmail.com>
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
…e metadata config (apache#16130) As per KIP-1022, we will rename the unstable metadata versions enabled config to support all feature versions. Features is also updated to return latest production and latest testing versions of each feature. A feature is production ready when the corresponding metadata version (bootstrapMetadataVersion) is production ready. Adds tests for the feature usage of the unstableFeatureVersionsEnabled config Reviewers: David Jacot <djacot@confluent.io>, Jun Rao <junrao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per KIP-1022, we will rename the unstable metadata versions enabled config to support all feature versions.
Features is also updated to return latest production and latest testing versions of each feature.
A feature is production ready when the corresponding metadata version (bootstrapMetadataVersion) is production ready.
Adds tests for the feature usage of the unstableFeatureVersionsEnabled config