MINOR: Refactor DynamicConfig#16133
Merged
chia7712 merged 3 commits intoapache:trunkfrom May 31, 2024
Merged
Conversation
chia7712
reviewed
May 30, 2024
|
|
||
| private def verifyReconfigurableConfigs(configNames: Set[String]): Unit = CoreUtils.inWriteLock(lock) { | ||
| val nonDynamic = configNames.filter(DynamicConfig.Broker.nonDynamicProps.contains) | ||
| val nonDynamic = configNames.filter(nonDynamicProps.contains) |
Member
There was a problem hiding this comment.
How about configNames.intersect(nonDynamicProps)?
| // Exclude message.format.version for now since we need to check that the version | ||
| // is supported on all brokers in the cluster. | ||
| @nowarn("cat=deprecation") | ||
| val ExcludedConfigs = Set(ServerLogConfigs.LOG_MESSAGE_FORMAT_VERSION_CONFIG) |
Member
There was a problem hiding this comment.
Do we need this variable? Maybe we can remove it by following change.
// Exclude message.format.version for now since we need to check that the version
// is supported on all brokers in the cluster.
@nowarn("cat=deprecation")
val ReconfigurableConfigs = ServerTopicConfigSynonyms.TOPIC_CONFIG_SYNONYMS.values.asScala.toSet - ServerLogConfigs.LOG_MESSAGE_FORMAT_VERSION_CONFIG
Member
Author
There was a problem hiding this comment.
I've inlined this variable but we need to keep it as a Set for the - operator to work
Member
There was a problem hiding this comment.
I don't run it actually, but IIRC "-" operator should work. See following screenshot
Please correct me for my Scala education 😄
Member
Author
There was a problem hiding this comment.
My bad, you are correct! I was trying to use the -- operator, hence why it needed both operands to be Sets. With - we don't need the Set. Thanks
chia7712
approved these changes
May 31, 2024
wernerdv
pushed a commit
to wernerdv/kafka
that referenced
this pull request
Jun 3, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Jun 8, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)