KAFKA-16715: Create KafkaShareConsumer interfaces#16134
Merged
omkreddy merged 5 commits intoapache:trunkfrom Jun 4, 2024
Merged
KAFKA-16715: Create KafkaShareConsumer interfaces#16134omkreddy merged 5 commits intoapache:trunkfrom
omkreddy merged 5 commits intoapache:trunkfrom
Conversation
Member
Author
|
The build will not succeed until #16022 is merged. |
Member
Author
|
Closing and re-opening PR to force rebuild. This should fix the build failures because of a recent merge. |
Contributor
|
there are checkstyle errors: |
omkreddy
reviewed
Jun 3, 2024
| * A mock of the {@link ShareConsumer} interface you can use for testing code that uses Kafka. This class is <i> not | ||
| * thread-safe </i>. | ||
| */ | ||
| public class MockShareConsumer<K, V> implements ShareConsumer<K, V> { |
Contributor
There was a problem hiding this comment.
Can we add tests to MockShareConsumer (similar to MockConsumerTest)?
Member
Author
There was a problem hiding this comment.
Ah, I hadn't done that because I was putting this in as essentially just the interfaces, but I can do that. I'll do that in the next commit.
AndrewJSchofield
force-pushed
the
KAFKA-16715
branch
from
2efcc16 to
9900d89
Compare
apoorvmittal10
approved these changes
Jun 3, 2024
Contributor
apoorvmittal10
left a comment
apoorvmittal10
left a comment
There was a problem hiding this comment.
Thanks for the PR. LGTM!
omkreddy
approved these changes
Jun 4, 2024
Contributor
omkreddy
left a comment
omkreddy
left a comment
There was a problem hiding this comment.
@AndrewJSchofield Thanks for the PR. LGTM
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Jun 8, 2024
This PR introduces ShareConsumer and KafkaShareConsumer. It is focused entirely on the minimal additions required to introduce the external programming interfaces. Reviewers: Apoorv Mittal <amittal@confluent.io>, Manikumar Reddy <manikumar.reddy@gmail.com>
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
This PR introduces ShareConsumer and KafkaShareConsumer. It is focused entirely on the minimal additions required to introduce the external programming interfaces. Reviewers: Apoorv Mittal <amittal@confluent.io>, Manikumar Reddy <manikumar.reddy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces ShareConsumer and KafkaShareConsumer. It is focused entirely on the minimal additions required to introduce the external programming interfaces.
Committer Checklist (excluded from commit message)