MINOR: Enable transaction verification with new group coordinator in TransactionsTest#16139
Merged
dajac merged 1 commit intoapache:trunkfrom May 30, 2024
Merged
Conversation
jolshan
approved these changes
May 30, 2024
Member
jolshan
left a comment
jolshan
left a comment
There was a problem hiding this comment.
LGTM as long as tests pass :)
chiacyu
pushed a commit
to chiacyu/kafka
that referenced
this pull request
Jun 1, 2024
…TransactionsTest (apache#16139) While working on apache#16120, I noticed that the transaction verification feature is disabled in `TransactionsTest` when the new group coordinator is enabled. We did this initially because the feature was not available in the new group coordinator but we fixed it a long time ago. We can enable it now. Reviewers: Justine Olshan <jolshan@confluent.io>
wernerdv
pushed a commit
to wernerdv/kafka
that referenced
this pull request
Jun 3, 2024
…TransactionsTest (apache#16139) While working on apache#16120, I noticed that the transaction verification feature is disabled in `TransactionsTest` when the new group coordinator is enabled. We did this initially because the feature was not available in the new group coordinator but we fixed it a long time ago. We can enable it now. Reviewers: Justine Olshan <jolshan@confluent.io>
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Jun 8, 2024
…TransactionsTest (apache#16139) While working on apache#16120, I noticed that the transaction verification feature is disabled in `TransactionsTest` when the new group coordinator is enabled. We did this initially because the feature was not available in the new group coordinator but we fixed it a long time ago. We can enable it now. Reviewers: Justine Olshan <jolshan@confluent.io>
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
…TransactionsTest (apache#16139) While working on apache#16120, I noticed that the transaction verification feature is disabled in `TransactionsTest` when the new group coordinator is enabled. We did this initially because the feature was not available in the new group coordinator but we fixed it a long time ago. We can enable it now. Reviewers: Justine Olshan <jolshan@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #16120, I noticed that the transaction verification feature is disabled in
TransactionsTestwhen the new group coordinator is enabled. We did this initially because the feature was not available in the new group coordinator but we fixed it a long time ago. We can enable it now.Committer Checklist (excluded from commit message)