Skip to content

KAFKA-16866 RemoteLogManagerTest.testCopyQuotaManagerConfig failing#16146

Merged
satishd merged 2 commits intoapache:trunkfrom
chia7712:KAFKA-16866
May 31, 2024
Merged

KAFKA-16866 RemoteLogManagerTest.testCopyQuotaManagerConfig failing#16146
satishd merged 2 commits intoapache:trunkfrom
chia7712:KAFKA-16866

Conversation

@chia7712
Copy link
Copy Markdown
Member

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Copy link
Copy Markdown
Member

@jolshan jolshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I knew these defaults were coming from somewhere. It is better to not hard code. 👍

Copy link
Copy Markdown
Member

@satishd satishd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chia7712 for the quick fix. LGTM.

@satishd
Copy link
Copy Markdown
Member

satishd commented May 31, 2024

A few failing tests are unrelated to the change. Merging this change to the trunk to unblock the test failures.

@satishd satishd merged commit b0fb2ac into apache:trunk May 31, 2024
chiacyu pushed a commit to chiacyu/kafka that referenced this pull request Jun 1, 2024
…pache#16146)

Reviewers: Justine Olshan <jolshan@confluent.io>, Satish Duggana <satishd@apache.org>
wernerdv pushed a commit to wernerdv/kafka that referenced this pull request Jun 3, 2024
…pache#16146)

Reviewers: Justine Olshan <jolshan@confluent.io>, Satish Duggana <satishd@apache.org>
TaiJuWu pushed a commit to TaiJuWu/kafka that referenced this pull request Jun 8, 2024
…pache#16146)

Reviewers: Justine Olshan <jolshan@confluent.io>, Satish Duggana <satishd@apache.org>
gongxuanzhang pushed a commit to gongxuanzhang/kafka that referenced this pull request Jun 12, 2024
…pache#16146)

Reviewers: Justine Olshan <jolshan@confluent.io>, Satish Duggana <satishd@apache.org>
@chia7712 chia7712 deleted the KAFKA-16866 branch September 13, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants