Skip to content

MINOR: Fix typo in MetadataVersion.IBP_4_0_IV0#16181

Merged
jolshan merged 1 commit intoapache:trunkfrom
dajac:fix-mv
Jun 4, 2024
Merged

MINOR: Fix typo in MetadataVersion.IBP_4_0_IV0#16181
jolshan merged 1 commit intoapache:trunkfrom
dajac:fix-mv

Conversation

@dajac
Copy link
Copy Markdown
Member

@dajac dajac commented Jun 3, 2024

This patch fixes a typo in MetadataVersion.IBP_4_0_IV0. It should be 0 not O.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@dajac dajac added the KIP-848 The Next Generation of the Consumer Rebalance Protocol label Jun 3, 2024
Copy link
Copy Markdown
Member

@jolshan jolshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this on the last review. Let's make sure the build passes.

@dajac
Copy link
Copy Markdown
Member Author

dajac commented Jun 3, 2024

Sorry I missed this on the last review. Let's make sure the build passes.

Really hard to catch so no worries.

Copy link
Copy Markdown
Contributor

@junrao junrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dajac : Thanks for the PR. LGTM

Copy link
Copy Markdown
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jolshan jolshan merged commit 53d592e into apache:trunk Jun 4, 2024
jolshan pushed a commit that referenced this pull request Jun 4, 2024
This patch fixes a typo in MetadataVersion.IBP_4_0_IV0. It should be 0 not O.

Reviewers: Justine Olshan <jolshan@confluent.io>, Jun Rao <junrao@gmail.com>,  Chia-Ping Tsai <chia7712@gmail.com>
@jolshan
Copy link
Copy Markdown
Member

jolshan commented Jun 4, 2024

Cherrypicked to 3.8 as well.

@dajac dajac deleted the fix-mv branch June 4, 2024 04:58
TaiJuWu pushed a commit to TaiJuWu/kafka that referenced this pull request Jun 8, 2024
This patch fixes a typo in MetadataVersion.IBP_4_0_IV0. It should be 0 not O.

Reviewers: Justine Olshan <jolshan@confluent.io>, Jun Rao <junrao@gmail.com>,  Chia-Ping Tsai <chia7712@gmail.com>
gongxuanzhang pushed a commit to gongxuanzhang/kafka that referenced this pull request Jun 12, 2024
This patch fixes a typo in MetadataVersion.IBP_4_0_IV0. It should be 0 not O.

Reviewers: Justine Olshan <jolshan@confluent.io>, Jun Rao <junrao@gmail.com>,  Chia-Ping Tsai <chia7712@gmail.com>
jolshan added a commit to jolshan/kafka that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

KIP-848 The Next Generation of the Consumer Rebalance Protocol

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants