Skip to content

KAFKA-16638 Align the naming convention for config and default variables in *Config classes#16289

Closed
EricLuGHub wants to merge 1 commit intoapache:trunkfrom
EricLuGHub:KAFKA-16638-v2
Closed

KAFKA-16638 Align the naming convention for config and default variables in *Config classes#16289
EricLuGHub wants to merge 1 commit intoapache:trunkfrom
EricLuGHub:KAFKA-16638-v2

Conversation

@EricLuGHub
Copy link
Copy Markdown

@EricLuGHub EricLuGHub commented Jun 11, 2024

The PR mainly consists of renaming _PROP to _CONFIG and suffixing _DEFAULT in the config files.
The classes include:

  • org.apache.kafka.raft.QuorumConfig
  • org.apache.kafka.storage.internals.log.LogConfig
  • org.apache.kafka.server.log.remote.storage.RemoteLogManagerConfig
  • org.apache.kafka.storage.internals.log.CleanerConfig

Jira: https://issues.apache.org/jira/browse/KAFKA-16638

Note:

I had another PR linked to the same ticket. However, certain adjustments were made and I wanted to revert back certain changes. The changes were mainly that the public interface would remain intact (as discussed with @OmniaGM) and the alignment changes would only be within the config classes mentioned above.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@EricLuGHub EricLuGHub changed the title completed renaming for CleanerConfig, RemoteLogManagerConfig, LogConf… [KAFKA-16638] Align the naming convention for config and default variables in *Config classes Jun 11, 2024
@EricLuGHub EricLuGHub changed the title [KAFKA-16638] Align the naming convention for config and default variables in *Config classes KAFKA-16638 Align the naming convention for config and default variables in *Config classes Jun 11, 2024
Copy link
Copy Markdown
Contributor

@OmniaGM OmniaGM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this cleanup. LGTM, I would just appreciate if we didn't merge this pr before #16116.

@chia7712
Copy link
Copy Markdown
Member

@EricLuGHub could you please fix the conflicts?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 5, 2025

This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.

If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact).

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

@github-actions github-actions bot added the stale Stale PRs label Jan 5, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 5, 2025

This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.

@github-actions github-actions bot added the closed-stale PRs that were closed due to inactivity label Feb 5, 2025
@github-actions github-actions bot closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed-stale PRs that were closed due to inactivity stale Stale PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants