Skip to content

KAFKA-15045: (KIP-924 pt. 23) More TaskAssignmentUtils tests#16292

Merged
ableegoldman merged 6 commits intoapache:trunkfrom
apourchet:KIP-924-22
Jun 12, 2024
Merged

KAFKA-15045: (KIP-924 pt. 23) More TaskAssignmentUtils tests#16292
ableegoldman merged 6 commits intoapache:trunkfrom
apourchet:KIP-924-22

Conversation

@apourchet
Copy link
Copy Markdown
Contributor

@apourchet apourchet commented Jun 11, 2024

Also moved the assignment validation test from
StreamsPartitionAssignorTest to TaskAssignmentUtilsTest.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@apourchet
KAFKA-15045: (KIP-924 pt. 22) More TaskAssignmentUtils tests
9543310 
Also moved the assignment validation test from
StreamsPartitionAssignorTest to TaskAssignmentUtilsTest.
ableegoldman
ableegoldman reviewed Jun 11, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing but otherwise looks good

Comment thread ...rc/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java Outdated
.map(TaskInfo::id)
.collect(Collectors.toSet());

// TODO: We need to use stateless traffic costs and non overlap costs here.
Copy link
Copy Markdown
Member

@ableegoldman ableegoldman Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably take this out just because you're already working on the PR that addresses this, and would have to rebase it to remove the TODO comment when this PR is merged which means retriggering the build on your other PR in like 4 hours

@ableegoldman ableegoldman mentioned this pull request Jun 12, 2024
Merged
3 tasks
@ableegoldman ableegoldman changed the title KAFKA-15045: (KIP-924 pt. 22) More TaskAssignmentUtils tests KAFKA-15045: (KIP-924 pt. 23) More TaskAssignmentUtils tests Jun 12, 2024
apourchet added 4 commits June 12, 2024 09:56
@apourchet
Squashed commit of the following:
4ba836d 
commit 9368ef8
Author: Gantigmaa Selenge <39860586+tinaselenge@users.noreply.github.com>
Date:   Wed Jun 12 16:04:24 2024 +0100

    KAFKA-16865: Add IncludeTopicAuthorizedOperations option for DescribeTopicPartitionsRequest (apache#16136)

    Reviewers: Mickael Maison <mickael.maison@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>, Calvin Liu <caliu@confluent.io>, Andrew Schofield <andrew_schofield@live.com>, Apoorv Mittal <amittal@confluent.io>

commit 46eb081
Author: gongxuanzhang <gongxuanzhang@foxmail.com>
Date:   Wed Jun 12 22:23:39 2024 +0800

    KAFKA-10787 Apply spotless to log4j-appender, trogdor, jmh-benchmarks, examples, shell and generator (apache#16296)

    Reviewers: Chia-Ping Tsai <chia7712@gmail.com>

commit 79b9c44
Author: gongxuanzhang <gongxuanzhang@foxmail.com>
Date:   Wed Jun 12 22:19:47 2024 +0800

    KAFKA-10787 Apply spotless to connect module (apache#16299)

    Reviewers: Chia-Ping Tsai <chia7712@gmail.com>

commit b5fb654
Author: Abhijeet Kumar <abhijeet.cse.kgp@gmail.com>
Date:   Wed Jun 12 19:47:46 2024 +0530

    KAFKA-15265: Dynamic broker configs for remote fetch/copy quotas (apache#16078)

    Reviewers: Kamal Chandraprakash<kamal.chandraprakash@gmail.com>, Satish Duggana <satishd@apache.org>

commit faee6a4
Author: Dmitry Werner <grimekillah@gmail.com>
Date:   Wed Jun 12 15:44:11 2024 +0500

    MINOR: Use predetermined dir IDs in ReplicationQuotasTest

    Use predetermined directory IDs instead of Uuid.randomUuid() in ReplicationQuotasTest.

    Reviewers: Igor Soarez <soarez@apple.com>

commit 638844f
Author: David Jacot <djacot@confluent.io>
Date:   Wed Jun 12 08:29:50 2024 +0200

    KAFKA-16770; [2/2] Coalesce records into bigger batches (apache#16215)

    This patch is the continuation of apache#15964. It introduces the records coalescing to the CoordinatorRuntime. It also introduces a new configuration `group.coordinator.append.linger.ms` which allows administrators to chose the linger time or disable it with zero. The new configuration defaults to 10ms.

    Reviewers: Jeff Kim <jeff.kim@confluent.io>, Justine Olshan <jolshan@confluent.io>

commit 39ffdea
Author: Bruno Cadonna <cadonna@apache.org>
Date:   Wed Jun 12 07:51:38 2024 +0200

    KAFKA-10199: Enable state updater by default (apache#16107)

    We have already enabled the state updater by default once.
    However, we ran into issues that forced us to disable it again.
    We think that we fixed those issues. So we want to enable the
    state updater again by default.

    Reviewers: Lucas Brutschy <lbrutschy@confluent.io>, Matthias J. Sax <matthias@confluent.io>

commit 0782232
Author: Antoine Pourchet <antoine@responsive.dev>
Date:   Tue Jun 11 22:31:43 2024 -0600

    KAFKA-15045: (KIP-924 pt. 22) Add RackAwareOptimizationParams and other minor TaskAssignmentUtils changes (apache#16294)

    We now provide a way to more easily customize the rack aware
    optimizations that we provide by way of a configuration class called
    RackAwareOptimizationParams.

    We also simplified the APIs for the optimizeXYZ utility functions since
    they were mutating the inputs anyway.

    Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>

commit 226ac5e
Author: Murali Basani <muralidhar.basani@aiven.io>
Date:   Wed Jun 12 05:38:50 2024 +0200

    KAFKA-16922 Adding unit tests for NewTopic  (apache#16255)

    Reviewers: Chia-Ping Tsai <chia7712@gmail.com>

commit 23fe71d
Author: Abhijeet Kumar <abhijeet.cse.kgp@gmail.com>
Date:   Wed Jun 12 06:27:02 2024 +0530

    KAFKA-15265: Integrate RLMQuotaManager for throttling copies to remote storage (apache#15820)

    - Added the integration of the quota manager to throttle copy requests to the remote storage. Reference KIP-956
    - Added unit-tests for the copy throttling logic.

    Reviewers: Satish Duggana <satishd@apache.org>, Luke Chen <showuon@gmail.com>, Kamal Chandraprakash<kamal.chandraprakash@gmail.com>

commit 2fa2c72
Author: Chris Egerton <chrise@aiven.io>
Date:   Tue Jun 11 23:15:07 2024 +0200

    MINOR: Wait for embedded clusters to start before using them in Connect OffsetsApiIntegrationTest (apache#16286)

    Reviewers: Greg Harris <greg.harris@aiven.io>
@apourchet
part 22 fixes
fc83e49
@apourchet
Merge branch 'trunk' into KIP-924-22
3b74e18
@apourchet
added ProcessId.randomProcessId function and cleaned up internals
c37fafe
ableegoldman
ableegoldman approved these changes Jun 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@ableegoldman ableegoldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, no notes -- will merge when the build finishes

@ableegoldman
Copy link
Copy Markdown
Member

ableegoldman commented Jun 12, 2024

Oh the build is already finished 😅 -- looks like all test failures are unrelated, merging to trunk

@ableegoldman ableegoldman merged commit 16e2b68 into apache:trunk Jun 12, 2024
ableegoldman pushed a commit that referenced this pull request Jun 12, 2024
@apourchet @ableegoldman
KAFKA-15045: (KIP-924 pt. 23) More TaskAssignmentUtils tests (#16292)
87264e6 
Also moved the assignment validation test from StreamsPartitionAssignorTest to TaskAssignmentUtilsTest.

Reviewers: Anna Sophie Blee-Goldman <ableegoldman@apache.org>
@ableegoldman
Copy link
Copy Markdown
Member

ableegoldman commented Jun 12, 2024

Merged to trunk and cherrypicked to 3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ableegoldman ableegoldman ableegoldman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@apourchet @ableegoldman