KAFKA-16921: migrate connect module to junit 5#16328
Merged
chia7712 merged 1 commit intoapache:trunkfrom Jun 14, 2024
Merged
Conversation
chia7712
reviewed
Jun 14, 2024
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@FrankYang0529 thanks for this patch. two comments are left.
* org.apache.kafka.connect.storage * org.apache.kafka.connect.test.util * org.apache.kafka.connect.util Signed-off-by: PoAn Yang <payang@apache.org>
FrankYang0529
force-pushed
the
KAFKA-16921
branch
from
207dd91 to
3e5ee2d
Compare
Member
Author
|
Hi @chia7712, thanks for your review. I addressed all comments. May you take a look? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)