KAFKA-16921: migrate connect module to junit 5 (Part 2)#16330
Merged
chia7712 merged 4 commits intoapache:trunkfrom Jun 14, 2024
Merged
KAFKA-16921: migrate connect module to junit 5 (Part 2)#16330chia7712 merged 4 commits intoapache:trunkfrom
chia7712 merged 4 commits intoapache:trunkfrom
Conversation
chia7712
reviewed
Jun 14, 2024
| super.starting(description); | ||
| log.info("Starting test {}", description.getMethodName()); | ||
| } | ||
| public class ConnectIntegrationTestUtils implements TestWatcher, BeforeEachCallback, AfterEachCallback { |
Member
There was a problem hiding this comment.
It seems this is used to log test name. Maybe we can move the log to each tests? There are only three class using this helper.
Collaborator
Author
There was a problem hiding this comment.
It's a good idea, I will remove it
Collaborator
Author
|
@chia7712, Thanks for your comment, PTAL |
Member
|
@m1a2st could you please take a look at failed tests? |
Member
|
failed tests pass on my local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/KAFKA-16921
Committer Checklist (excluded from commit message)