Conversation
showuon
left a comment
showuon
left a comment
There was a problem hiding this comment.
LGTM! But it might be better if you could run this doc change locally and have screenshot to make sure it works as expected, especially the quickstart section. Thanks.
|
It's not easy since this includes changes all over the website. Like for code changes, reviewers should test this change locally. |
|
If it's a pain to review, I can split the PR. |
It's fine. It looks good. Thanks. |
- Remove line numbers for non-code formatted blocks - Use consistent prompt $ for all bash commands - Remove outdated zookeeper content - Cleanup of HTML formatting
| <p>Invoke the application reset tool from the command line</p> | ||
| <p>Warning! This tool makes irreversible changes to your application. It is strongly recommended that you run this once with <code class="docutils literal"><span class="pre">--dry-run</span></code> to preview your changes before making them.</p> | ||
| <pre class="line-numbers"><code class="language-bash"><path-to-kafka>/bin/kafka-streams-application-reset</code></pre> | ||
| <pre<code class="language-bash">$ bin/kafka-streams-application-reset</code></pre> |
| <h4 class="anchor-heading"><a id="record" class="anchor-link"></a><a href="#record">5.3.2 Record</a></h4> | ||
| <p>Record level headers were introduced in Kafka 0.11.0. The on-disk format of a record with Headers is delineated below. </p> | ||
| <pre class="line-numbers"><code class="language-text">length: varint | ||
| <pre"><code class="language-text">length: varint |
|
Since all changes are to |
Reviewers: Luke Chen <showuon@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
|
@mimaison would it be possible to backport this to 3.8, since it contains a syntax fix for the Connect quickstart? I've opened apache/kafka-site#615 to port that specific change over to our docs site, but want to make sure it doesn't get overwritten when we publish 3.8.1. |
|
Yeah ideally we'd like want to sync all these to the website before 3.9. Should we wait for 3.8.0 to be out before backporting to 3.8? |
|
Yeah, that should be fine, thanks! |
Reviewers: Luke Chen <showuon@gmail.com>, Chia-Ping Tsai <chia7712@gmail.com>
|
Backported to 3.8: 57c50e3 |
|
Shall we mimic this PR in |
|
Yes, I'll open a PR for kafka-site this afternoon. |
|
Ping me and I'll review it |
5 participants
Committer Checklist (excluded from commit message)