KAFKA-15853: Refactor ShareGroupConfig with AbstractConfig

[OmniaGM]

Move getters and validation out of KafkaConfig and into ShareGroupConfig

Committer Checklist (excluded from commit message)

• Verify design and implementation
• Verify test coverage and CI build status
• Verify documentation (including upgrade notes)

[OmniaGM]

@chia7712 can you have a look please whenever you have time? I started with this as the KIP-932 is under development at the moment and I don't want to clash with it

[chia7712]

@OmniaGM that refactor is good, but maybe we can reach more consensus before refactor. Please take a look at #16458 (comment)

It would be nice we can build a pattern for all xxxConfig files.

[chia7712]

@OmniaGM as the summary of #16458 (comment), if the ShareGroupConfig is not dynamic we can introduce local attributes and validate all of them in construction. That can make sure each ShareGroupConfig is totally valid.

[OmniaGM]

@OmniaGM as the summary of #16458 (comment), if the ShareGroupConfig is not dynamic we can introduce local attributes and validate all of them in construction. That can make sure each ShareGroupConfig is totally valid.

Just pushed a refactor here 5b4b862 to introduce attributes and move the validation to the construction. Please have a look when you have time.

[chia7712]

@OmniaGM thanks for this patch. only two small comments 😄

[AndrewJSchofield]

lgtm. I was wondering how the refactoring that @OmniaGM is doing for config would affect the work we are doing on KIP-932.

[OmniaGM]

lgtm. I was wondering how the refactoring that @OmniaGM is doing for config would affect the work we are doing on KIP-932.

@AndrewJSchofield I believe it shouldn't have significant effect on KIP-932's work apart from the fact that now all getters, validation and config definitions will be defined in ShareGroupConfig. Specially that as far as I can see we still didn't define all broker configs defined in KIP-932 yet. This also should reduce conflicts between refactoring KafkaConfig and broker config part of KIP-932.

Small suggestion you can depends on ShareGroupConfig instead of the full KafkaConfig where config is needed now if you wish.

[apoorvmittal10]

Thanks for the PR @OmniaGM, I do see GroupCoordinatorConfig also follows new way for configs 👍