KAFKA-17122 Change the type of clusterId from UUID to String#16590
Merged
chia7712 merged 1 commit intoapache:trunkfrom Jul 19, 2024
Merged
KAFKA-17122 Change the type of clusterId from UUID to String#16590chia7712 merged 1 commit intoapache:trunkfrom
clusterId from UUID to String#16590chia7712 merged 1 commit intoapache:trunkfrom
Conversation
Member
|
@soravolk Please run |
soravolk
force-pushed
the
KAFKA-17122
branch
2 times, most recently
from
bcca680 to
17862ab
Compare
Contributor
Author
|
@chia7712 Thank you for the reminder. I have fixed the import order. |
Member
|
@soravolk please make sure the build before pushing the updates ... |
Contributor
Author
|
@chia7712 I apologize for my oversight in the previous version. I have now made the necessary updates. |
abhi-ksolves
pushed a commit
to ksolves/kafka
that referenced
this pull request
Jul 31, 2024
…pache#16590) Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the discussion: #14628 (comment)
Since the uuid constrain no longer holds after 3.7, it is better to modify the type from
UuidtoStringto clarify the intention behind theclusterIdfor the current version.Committer Checklist (excluded from commit message)