MINOR: Update collaborators list#16679
Conversation
|
Nice PR one problem with the used command is that any one that has same email but different name attached to the commit don't count as one person. I tried this which basically drop the name and use emails only from the output of and got slightly different order. Note my bash skills isn't the best :D |
|
I can give it a try and hope we don't have two people with the same name 😃 |
|
maybe we should ping those active contributors to take a look at this PR. Otherwise, they could never know that permission. |
My script do count based on email only not names, so it should be safer and bit accurate. This == 31 which should be right after Same with others |
|
I think the tricky part would be same person two emails :D but I can't find such one in the original |
another case: Those active contributors have many alias :) |
|
How about using Github contributors page? https://github.com/apache/kafka/graphs/contributors?from=2023-07-24&to=2024-07-24&type=c |
Yes this is me. |
yup this is the tricky one I mentioned above same person different emails :D |
|
I think this is the most accurate one at least it count for these GitHub email and name issue. And for cases where someone is mixing different accounts then sadly this case can't be counted as one person. |
Yes @chia7712 , I was planning on doing this once we had the changes merged to make sure the pinged people were the ones that made it to the list for sure. |
|
I updated KAFKA-14995 to reflect this way to obtain the contributors that seems more fair than the one with emails or names. |
|
I'll merge this PR, as the pipelines don't check this file and we don't need to waste CPU cycles on this. Mentioning the newly added collaborators here as an FYI - @FrankYang0529 @apoorvmittal10 @lianetm @brandboat @kirktrue @nizhikov @OmniaGM @dongnuo123 @frankvicky . Welcome all! Let us know if you have any questions! You can check out the Collaborators section on https://kafka.apache.org/contributing, or this dev mailing list thread for more details. |
* MINOR: Update collaborators list using GH contributors page Reviewers: Chia-Ping Tsai <chia7712@gmail.com>, Omnia Ibrahim <o.g.h.ibrahim@gmail.com>
I did the following:
Then I excluded all committers from the list.
Cut the list to the top 10 and for each member I found their GitHub user name. List is in order of commits.
Note I used the
--emailflag as stated in https://issues.apache.org/jira/browse/KAFKA-14995Committer Checklist (excluded from commit message)