KAFKA-17337: ConsumerConfig should default to CONSUMER for group.protocol#17107
Closed
kirktrue wants to merge 19 commits intoapache:trunkfrom
kirktrue:KAFKA-17337-default-to-CONSUMER-group-protocol
Closed
KAFKA-17337: ConsumerConfig should default to CONSUMER for group.protocol#17107kirktrue wants to merge 19 commits intoapache:trunkfrom kirktrue:KAFKA-17337-default-to-CONSUMER-group-protocol
kirktrue wants to merge 19 commits intoapache:trunkfrom
kirktrue:KAFKA-17337-default-to-CONSUMER-group-protocol
Conversation
…ocol Updated DEFAULT_GROUP_PROTOCOL to use CONSUMER instead of CLASSIC, updated GROUP_PROTOCOL_DOC to be a little more flexible going forward, and cleaned up unit tests that assumed CLASSIC as the default.
kirktrue
added
consumer
KIP-848
Contributor
Author
|
I would like to run the system tests with this change before review. |
For some reason, listing all the GroupProtocol options dynamically led to a StackOverflowError. Changed it to list the protocols explicitly to avoid this.
The system is out of resources.
Consult the following stack trace for details.
java.lang.StackOverflowError
at com.sun.tools.javac.comp.Attr.visitLambda(Attr.java:2296)
at com.sun.tools.javac.tree.JCTree$JCLambda.accept(JCTree.java:1624)
at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:576)
at com.sun.tools.javac.comp.Attr.visitLambda(Attr.java:2435)
at com.sun.tools.javac.tree.JCTree$JCLambda.accept(JCTree.java:1624)
at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:576)
at com.sun.tools.javac.comp.Attr.visitLambda(Attr.java:2435)
at com.sun.tools.javac.tree.JCTree$JCLambda.accept(JCTree.java:1624)
at com.sun.tools.javac.comp.Attr.attribTree(Attr.java:576)
at com.sun.tools.javac.comp.Attr.visitLambda(Attr.java:2435)
at com.sun.tools.javac.tree.JCTree$JCLambda.accept(JCTree.java:1624)
…to-CONSUMER-group-protocol
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
DEFAULT_GROUP_PROTOCOLto useCONSUMERinstead ofCLASSIC, updatedGROUP_PROTOCOL_DOCto be a little more flexible going forward, and cleaned up unit tests that assumedCLASSICas the default group protocol.Committer Checklist (excluded from commit message)