KAFKA-17492: skip KIP-584 features with minVersion of 0 in older RPCs#17143
Closed
KAFKA-17492: skip KIP-584 features with minVersion of 0 in older RPCs#17143
Conversation
Some older clients will have deserialization problems if a KIP-584 feature's minimum supported level is 0. Therefore, when preparing an ApiVersionResponse for a version less than 4, we must omit features with a minimum supported level of 0. This is reasonable to do because older software could not handle setting these features to a level other than 0 in any case. A similar problem applies to BrokerRegistrationRequest. Here we must omit features with minVersion = 0 when the RPC version is less than 4. Note that this fix supersedes an earlier compatibility preservation effort in KAFKA-17011.
Contributor
Author
|
This was fixed by #17128. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some older clients will have deserialization problems if a KIP-584 feature's minimum supported level is 0. Therefore, when preparing an ApiVersionResponse for a version less than 4, we must omit features with a minimum supported level of 0. This is reasonable to do because older software could not handle setting these features to a level other than 0 in any case.
A similar problem applies to BrokerRegistrationRequest. Here we must omit features with minVersion = 0 when the RPC version is less than 4.
Note that this fix supersedes an earlier compatibility preservation effort in KAFKA-17011.